[Kde-pim] Review Request 109247: Make Toolbar Buttons Show Message Status

[Andras Mantia]

> On March 5, 2013, 3:54 p.m., Laurent Montel wrote:
> > Seems correct.
> > Ship it in 4.10 I will merge after in master
> > (if you can't I will apply it)

I already told to him in person, but I will also say it here: note that with the patch the action in the context menu looks a  little weird, it will say "[x] Remove Important Mark".
I'm not against the patch as indeed, this makes sense when the action is on the toolbar and I have no real solution for the problem (aside of not changing the action name, but just keeping the checkable state).


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109247/#review28589
-----------------------------------------------------------


On March 2, 2013, 4:57 p.m., Torsten Grote wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109247/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 4:57 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Àlex Fiestas and Laurent Montel.
> 
> 
> Description
> -------
> 
> If you have "Mark Mail as Important" and  "Mark Mail as Action Item" in the KMail Toolbar, the buttons are now visually checked again if the message has already one of those statuses.
> 
> 
> Diffs
> -----
> 
>   akonadi/kmime/standardmailactionmanager.cpp c9d442dba5d9504b4040053b9b3df16e926a8d16 
> 
> Diff: http://git.reviewboard.kde.org/r/109247/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten Grote
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/