[Kde-pim] Review Request 109250: Fetch missing body parts in the IMAP resource. Part 3/3

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109250/#review28425
-----------------------------------------------------------



resources/imap/imapresource.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21215>

    Whitespaces issue.



resources/imap/imapresource.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21217>

    Just wondering, why is the extra session needed?



resources/imap/retrieveitemstask.h
<http://git.reviewboard.kde.org/r/109250/#comment21226>

    Hmmm... Looks like something which should be in ResourceTask. Could you make a separate commit for it and make sure all the tasks we generate in the resource have their status() signal connected?



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21218>

    Whitespaces issue.



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21221>

    Whitespace missing after =



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21219>

    Whitespaces issue.



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21220>

    Whitespaces issue.



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21222>

    You don't need this extra empty line.



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21223>

    Whitespaces issue.



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21224>

    Whitespaces issue.



resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21225>

    Whitespaces issue.


- Kevin Ottens


On March 3, 2013, 12:40 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109250/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 12:40 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Ottens and Volker Krause.
> 
> 
> Description
> -------
> 
> This part makes sure the IMAP resources caches the full body if it was missing for whatever reason from the cache. This covers the transition from an online IMAP account to a disconnected one, and also fixes the cache if it was corrupted (as it happened in any KDE < master so far on account removal).
> 
> 
> Diffs
> -----
> 
>   resources/imap/retrieveitemstask.cpp cf96dc8 
>   resources/imap/retrieveitemstask.h 672171a 
>   resources/imap/imapresource.cpp 9471eb3 
>   resources/imap/imapresource.h 078d202 
> 
> Diff: http://git.reviewboard.kde.org/r/109250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/