[Kde-pim] Review Request 109259: Remove inode/directory from MailCommon::FolderCollectionMonitor

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109259/#review28487
-----------------------------------------------------------


> fix a problem, that removing a completely unrelated resource (like Google Calendar
> was totally messing up KMail's folder view (usually leading to crash).

How does it fix that? By not going thru the code path which makes kmail crash? But then the crashing bug is still there, it is just not triggered. Is it safe to assume that this dangerous code path is never taken elsewhere? To me, a bug messing up the folder view and crashing seems to be worthy of its own investigation, but you are removing one (although maybe the only one) way how to trigger it.

- Wolfgang Rohdewald


On March 3, 2013, 2:59 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109259/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 2:59 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Don't watch collections in KMail that KMail is not really interested in. This should improve performance a bit and fix a problem, that removing a completely unrelated resource (like Google Calendar) was totally messing up KMail's folder view (usually leading to crash).
> 
> I assume this was added as a workaround for a bug in Monitor, that collections trees where the root collection did not match the mimetype filter were ignored. This has been fixed some time ago, so this is not needed anymore.
> 
> 
> Diffs
> -----
> 
>   mailcommon/foldercollectionmonitor.cpp 49de537 
> 
> Diff: http://git.reviewboard.kde.org/r/109259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/