[Kde-pim] Review Request 109258: Progress items: Use EntityDisplayAttribute::displayName for the user-visible string if set

Kevin Krammer krammer at kde.org
Sun Mar 3 15:05:56 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109258/#review28441
-----------------------------------------------------------



akonadi/resourcebase.cpp
<http://git.reviewboard.kde.org/r/109258/#comment21249>

    style nit pick: block brackets {} for then and else


- Kevin Krammer


On March 3, 2013, 2:51 p.m., Frank Osterfeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109258/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 2:51 p.m.)
> 
> 
> Review request for Akonadi, Kevin Ottens, Tobias Koenig, and Volker Krause.
> 
> 
> Description
> -------
> 
> Use EntityDisplayAttribute::displayName for the user-visible progress string if set
> 
> 
> Diffs
> -----
> 
>   akonadi/resourcebase.cpp f1b28f3 
> 
> Diff: http://git.reviewboard.kde.org/r/109258/diff/
> 
> 
> Testing
> -------
> 
> Tested with krsslocalresource, where the displayname differs from the collection name.
> 
> 
> Thanks,
> 
> Frank Osterfeld
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list