[Kde-pim] Review Request 109291: Adding Qt::ToolTipRole to models where Qt::DisplayRole is used: provides tool tips

[Thomas Fischer]

> On March 5, 2013, 8:52 p.m., Kevin Krammer wrote:
> > kaddressbook/xxport/csv/templateselectiondialog.cpp, line 3
> > <http://git.reviewboard.kde.org/r/109291/diff/1/?file=117056#file117056line3>
> >
> >     that seems an unrelated change

I used Kate. Most probably I pressed Ctrl+D (comment line) instead of Ctrl+S for saving. Just ignore it ...


On March 5, 2013, 8:52 p.m., Thomas Fischer wrote:
> > Looks technically OK, but I am wondering if this will not make tool tips appear all over the place when the mouse is just resting somewhere on the view

There are already a lot of tool tips in use. For example, in KMail both the folder view and the list of mails have (nice) tool tips which appear as soon as one rests the mouse.
I have to admit that I haven't tested every case where I added a Qt::ToolTipRole case, so it may happen that it is annoying in some cases. I may be biased here, but I see the benefits of tool tips outweigh the potential annoyances. Therefore, I would like to recommend to accept the patch (minus the commenting of Tobias Koenig) and remove single tool tips later if they become a problem.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109291/#review28614
-----------------------------------------------------------


On March 5, 2013, 12:17 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109291/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 12:17 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The attached patch adds tool tips via Qt::ToolTipRole in many places where a display string is provided via Qt::DisplayRole. This provides a better usability in cases where e.g. columns in lists are too narrow to show the cells' full text.
> 
> 
> Diffs
> -----
> 
>   akonadiconsole/agentconfigmodel.cpp 853e072 
>   akonadiconsole/akonadibrowsermodel.cpp 97e9203 
>   akonadiconsole/jobtrackermodel.cpp d39694a 
>   akonadiconsole/notificationmodel.cpp 6989137 
>   calendarviews/todo/todomodel.cpp 8f36ea6 
>   examples/akonablog/blogmodel.cpp 2c5bde6 
>   examples/coisceim/mixedtreemodel.cpp 46e13c4 
>   examples/etm_usage/mailmodel.cpp 22fc7f4 
>   examples/etm_usage/mixedtreemodel.cpp adb929f 
>   incidenceeditor-ng/freebusyitemmodel.cpp ef2a192 
>   kaddressbook/xxport/csv/qcsvmodel.cpp 84f44e3 
>   kaddressbook/xxport/csv/templateselectiondialog.cpp e2d8aec 
>   kalarm/akonadimodel.cpp c4d8835 
>   kalarm/birthdaymodel.cpp f5191e1 
>   kalarm/eventlistmodel.cpp 3d5bffe 
>   kjots/kjotsmodel.cpp c22fce7 
>   knode/composer/attachment_view.cpp d00300a 
>   libkleo/ui/directoryserviceswidget.cpp 9f1ff2a 
>   mailcommon/filter/filtermodel.cpp d68b0b8 
>   mailcommon/foldertreewidgetproxymodel.cpp c2623a2 
>   messagecomposer/attachmentmodel.cpp ade9292 
>   mobile/contacts/contactcompletionmodel.cpp 5b9a1ee 
>   mobile/contacts/locationmodel.cpp 657aa52 
>   mobile/lib/breadcrumbnavigation.cpp de1a0c0 
>   mobile/mail/templateemailmodel.cpp 2ba07f8 
> 
> Diff: http://git.reviewboard.kde.org/r/109291/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/