[Kde-pim] Review Request 109578: fixing templateparsertest

Allen Winter winter at kde.org
Sat Mar 23 15:05:26 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109578/#review29756
-----------------------------------------------------------

Ship it!


Ship It!

- Allen Winter


On March 19, 2013, 3:04 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109578/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 3:04 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> * make the templateparsertest run again successfully
> * add a inline mail to test decryption for reply/forward
> 
> parser.processWithTemplate relys on mOrigMsg, that is set via parser.process, but process also makes magic to figuer out, what templte to be used to replay/forward.
> The easiest solution to make the protected variable mOrigMsg public for the tests.
> 
> 
> Diffs
> -----
> 
>   templateparser/templateparser.h 1d2cd84027d8dd7bdceba709599751e059752e5f 
>   templateparser/tests/templateparsertest.cpp 3b1c219cb4fbd8a39e1aebdfb1e492ec2828283f 
> 
> Diff: http://git.reviewboard.kde.org/r/109578/diff/
> 
> 
> Testing
> -------
> 
> run test
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list