[Kde-pim] Review Request 109350: update gnupg test enviroment - get rid of pinentry window

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109350/#review28874
-----------------------------------------------------------



messagecore/tests/gnupg_home/pinentry-fake.sh
<http://git.reviewboard.kde.org/r/109350/#comment21609>

    might be worth testing with a different shell, e.g. dash, and then change to /bin/sh
    Some systems don't have bash as their default shell and might not ship it by default



messagecore/tests/util.cpp
<http://git.reviewboard.kde.org/r/109350/#comment21608>

    Maybe just call it more generically setupEnv or setupEnvVariables
    Only the first entry is for GNUPG


- Kevin Krammer


On March 8, 2013, 10:33 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109350/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 10:33 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> to make automated tests with jenkins, there must be a proper gnupg envrionment.
> 
> The only missing part is to run a gpg-agent.
> 
> To run the tests:
> 
> export GNUPGHOME=/home/kdetest/kde/build/messagecore/tests/gnupg_home
> eval $(gpg-agent)
> make test
> 
> furthermore I moved the setting of the gnupg environment to messagecore/tests/utils.cpp.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/tests/CMakeLists.txt 73efe4812c80fb9a2edde37a24999a48a4fc12a6 
>   messagecore/tests/CMakeLists.txt eba87cecc732111f2ff84e6cd63333f11adfc7c3 
>   messagecore/tests/gnupg_home/CMakeLists.txt PRE-CREATION 
>   messagecore/tests/gnupg_home/gpg-agent.conf db2f004ae18e182014526d54bd02f7ac07e32172 
>   messagecore/tests/gnupg_home/gpg-agent.conf.in PRE-CREATION 
>   messagecore/tests/gnupg_home/pinentry-fake.sh PRE-CREATION 
>   messagecore/tests/util.h 8bf55fe34ac379afa3471b8be1f62eda84ce8b2f 
>   messagecore/tests/util.cpp 8909c6b9900a627ea90b02c2c1614438348e772a 
>   messageviewer/tests/CMakeLists.txt fe2d3b9b4c6ba5b769715f3e1341b6a5c3f67258 
>   messageviewer/tests/objecttreeparsertest.cpp ded141a6444a98392096984ad8f29fc4ea2b2210 
>   messageviewer/tests/rendertest.cpp 1bcf0d2035babaa33049bf0cb1927012e9203cee 
>   messageviewer/tests/unencryptedmessagetest.cpp 6b3dc7649b171df1746a8b43842da0690127a6bb 
> 
> Diff: http://git.reviewboard.kde.org/r/109350/diff/
> 
> 
> Testing
> -------
> 
> run tests in messagecore, messageviewer and messagecomposer successfully.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/