[Kde-pim] Review Request 103382: Hide read feeds feature

[Kevin Tardif]

> On March 12, 2013, 7:29 p.m., Torgny Nyblom wrote:
> > Is this review still valid?

Valid in what way? Actually just I noticed I didn't mark the changes in the last diff, my apologies; it was just a line conflict from what I remember.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103382/#review29090
-----------------------------------------------------------


On Nov. 7, 2012, 8:09 p.m., Kevin Tardif wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103382/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 8:09 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patch adds a new option, to hide feeds with zero unread count from the feed list. You can access the setting via either the View menubar item or via the General configuration panel, it defaults to being turned off. The associated bug report for this is https://bugs.kde.org/show_bug.cgi?id=104277 which was prematurely closed due to misunderstanding of what the feature was.
> 
> List of file modifications:
> 
> subscriptionlistmodel:
>     - filter models are present in articlelistview, but controller only
>       includes listmodel.h, so I put FilterUnreadProxyModel here
> 
>     - added FilterUnreadProxyModel, a QSortFilerProxyModel subclass to
>       filter out feeds with zero unread count
>     - uint nodeIdForIndex(const QModelIndex&) is now a file-specific method
>     - changed FolderExpansionHandler::m_model to be of type
>       QAbstractItemModel* (since it no longer needs
>       SubscriptionListModel::nodeIdForIndex)
>     - segfault occurs on exit in SubscriptionListModel::index,
>       nodeForIndex returns NULL; added a check for null return here
> 
> selectioncontroller:
>     - hooked filter's selectionmodel's selectionChanged signal in
>       SelectionController::setFeedSelector to the FilterUnreadProxyModel
>       instance
>     - m_subscriptionModel is now a FilterUnreadProxyModel*
>     - added SelectionController::settingsChanged slot
>     - changed SelectionController::setFeedList to set the proxy's source
>     - model
> 
> actionmanagerimpl:
>     - added slotSettingsChanged slot for receiving
>       MainWidget::signalSettingsChange signal and updating action state
>     - added a KAction to ActionManagerImpl:initSubscriptionListView,
>       connected to SubscriptionListView::slotToggleHideReadFeeds
> 
> subscriptionlistview:
>     - added a public slot to connect the added action to (slotToggleHideReadFeeds)
> 
> mainwidget:
>     - hooked m_part's signalSettingsChanged() to m_selectionController::settingsChanged,
>       m_actionManager::slotSettingsChanged
> 
> interfaces/akregator.kcfg:
>     - added View/HideReadFeeds entry
> 
> akregator_part.rc:
>     - add a separator and an action to <Menu name="view"> (name=feed_hide_read)
> 
> settings_general.ui:
>     - add kcfg_HideReadFeeds field under General->Global
> 
> 
> Diffs
> -----
> 
>   akregator/src/subscriptionlistview.h 2f147d87a33d853927459e27ac413b0477693318 
>   akregator/src/subscriptionlistview.cpp 6ae64aa2b4f2309f05a50a8c26000339e41ab55d 
>   akregator/src/selectioncontroller.cpp 32df83e1e67a3a017d99de0e98f104843b41da15 
>   akregator/src/subscriptionlistmodel.h ad855ef82b5f07d43c580bb1e0327207bb06dd88 
>   akregator/src/subscriptionlistmodel.cpp 5491d3204683eef992f8384f8dba9e8489e33b22 
>   akregator/src/selectioncontroller.h ee0f9da1214afb194bb760300d1312e2b2a3507c 
>   akregator/src/akregator_part.rc cd7cc133a214db73a6052e993ae7aca24c33c5f4 
>   akregator/src/mainwidget.cpp 544a5b1bbdc6acbac73fac9e6f1b67d9ec0bb853 
>   akregator/src/actionmanagerimpl.h 53c11be7ed3db96a158277f020bd55ec02615ca7 
>   akregator/src/actionmanagerimpl.cpp d6d432e74b88bfed7e116dff9d3961207eb7e43c 
>   akregator/interfaces/akregator.kcfg c715100370b5260542fad56ebab11b127228dd7f 
>   akregator/configuration/settings_general.ui 1e9fd0e9554266aea195198bd92f7eb014edf831 
> 
> Diff: http://git.reviewboard.kde.org/r/103382/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Tardif
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/