[Kde-pim] Review Request 109634: Fix 313478: newline issue with for gpg inline signed mails

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109634/#review29612
-----------------------------------------------------------


Seems good.
For me it will fix 313478 I didn't test patch but for me it seems good.

Regards

- Laurent Montel


On March 21, 2013, 3:29 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109634/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 3:29 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Newlines for GPG inline signed/enc+signed mails are wrong encoded.
> \n are replaced by \r\n before creating the signature. This is
> not recommended for inline messages and breaks the signature.
> 
> Exclude GPG inline messages from KMime::LFtoCRLF before pushing to signing job.
> 
> My wild guess is, that this patch lso fixes one part of #303305
> 
> 
> This addresses bugs 303305 and 313478.
>     http://bugs.kde.org/show_bug.cgi?id=303305
>     http://bugs.kde.org/show_bug.cgi?id=313478
> 
> 
> Diffs
> -----
> 
>   messagecomposer/signencryptjob.cpp 76dd20947084f83dc2d4098e6a572bfb43661397 
>   messagecomposer/signjob.cpp 5133e05506b612e03665301036243cd7804dc160 
> 
> Diff: http://git.reviewboard.kde.org/r/109634/diff/
> 
> 
> Testing
> -------
> 
> create&test signed, encrypted and sign+encrypted messages for PGPMime, PGP inline, SMIME and SMIME Opaque with newlines. with the content and CTE quotedPrintable:
> 
> All happy families are alike;\n\n\n\neach unhappy family is unhappy in its own way.\n--\n hallloasdfasdfsadfsdf asdf sadfasdf sdf sdf sdf sadfasdf sdaf daf sdf asdf sadf asdf asdf [ä].
> 
> cd messagecomposer && gpg-agent --daemon make test
> Running tests...
> Test project /home/kdetest/kde/build/kdepim/messagecomposer
>       Start  1: messagecomposer-utiltest
>  1/12 Test  #1: messagecomposer-utiltest .................   Passed    0.32 sec
>       Start  2: messagecomposer-messagefactorytest
>  2/12 Test  #2: messagecomposer-messagefactorytest .......***Failed    0.79 sec
>       Start  3: messagecomposer-skeletonmessagejobtest
>  3/12 Test  #3: messagecomposer-skeletonmessagejobtest ...   Passed    0.12 sec
>       Start  4: messagecomposer-singlepartjobtest
>  4/12 Test  #4: messagecomposer-singlepartjobtest ........   Passed    0.11 sec
>       Start  5: messagecomposer-multipartjobtest
>  5/12 Test  #5: messagecomposer-multipartjobtest .........   Passed    0.10 sec
>       Start  6: messagecomposer-attachmentjobtest
>  6/12 Test  #6: messagecomposer-attachmentjobtest ........   Passed    0.10 sec
>       Start  7: messagecomposer-maintextjobtest
>  7/12 Test  #7: messagecomposer-maintextjobtest ..........***Failed    0.23 sec
>       Start  8: messagecomposer-composertest
>  8/12 Test  #8: messagecomposer-composertest .............   Passed    0.15 sec
>       Start  9: messagecomposer-cryptocomposertest
>  9/12 Test  #9: messagecomposer-cryptocomposertest .......   Passed   12.06 sec
>       Start 10: messagecomposer-signjobtest
> 10/12 Test #10: messagecomposer-signjobtest ..............   Passed    0.49 sec
>       Start 11: messagecomposer-encryptjobtest
> 11/12 Test #11: messagecomposer-encryptjobtest ...........   Passed    0.43 sec
>       Start 12: messagecomposer-signencrypttest
> 12/12 Test #12: messagecomposer-signencrypttest ..........   Passed    0.49 sec
> 
> 83% tests passed, 2 tests failed out of 12
> 
> Total Test time (real) =  15.41 sec
> 
> The following tests FAILED:
>           2 - messagecomposer-messagefactorytest (Failed)
>           7 - messagecomposer-maintextjobtest (Failed)
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/