[Kde-pim] Review Request 109299: fix nepomuk warnings

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109299/#review28661
-----------------------------------------------------------

Ship it!


The QueryServiceClient does provide the serviceAvailibilityChanged( bool running ) signal. Perhaps you could use that instead of checking each time?

Though the check in mService->serviceAvailable() shouldn't be too expensive. It's just a simple DBus isServiceRegistered call.

- Vishesh Handa


On March 5, 2013, 9:43 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109299/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 9:43 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Nepomuk is disabled.
> 
> whenever I look a a different message in kmail, I get this on stderr:
> QStringList Akonadi::NepomukSearch::search(const QString&) Calling blockingQuery() failed!
> 
> with this fix I get:
> Nepomuk search service not available!
> 
> and I improved some other warning/error messages.
> 
> The question remains why kmail tries this for every message even with nepomuk disabled.
> Doesn't nepomuk somehow tell kmail/akonadi when it gets enabled/disabled?
> 
> 
> Diffs
> -----
> 
>   server/src/handler/akappend.cpp 4253c42a810e4f478c12afba1f6988a6a8e2a0e5 
>   server/src/handler/append.cpp 2928fa47911da3b3c98d215bae54c51ef5e8c811 
>   server/src/nepomuksearch.cpp caf38a9c138d37ecdd1ec925433cbdbc9defc849 
> 
> Diff: http://git.reviewboard.kde.org/r/109299/diff/
> 
> 
> Testing
> -------
> 
> With nepomuk enabled, no warning. With nepomuk disabled, correct warning.
> 
> 
> Thanks,
> 
> Wolfgang Rohdewald
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/