[Kde-pim] Review Request 109576: Fixing parsing inline messages with objectTreeParser

Sat Mar 23 14:53:50 GMT 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109576/#review29754
-----------------------------------------------------------

Ship it!

yep

- Allen Winter

On March 21, 2013, 12:21 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109576/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 12:21 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Fixing parsing inline messages with objectTreeParser
> 
> If an inline message is parsed with objectTreeParser::parseObjectTree
> a malformed html is generated, and plainText will have an additionally
> newline:
> 
>   <body>
>     <div style="position: relative; word-wrap: break-word">
>       <a name="att"/>
>       <div id="attachmentDiv">
>         <table cellspacing="1" cellpadding="1" class="encr">
>           <tr class="encrH">
>             <td dir="ltr">Encrypted message</td>
>           </tr>
>           <tr class="encrB">
>             <td>
>               <div class="noquote">
>                 <div dir="ltr">some random text</div>
>               </div>
>             </td>
>           </tr>
>           <tr class="encrH">
>             <td dir="ltr">End of encrypted message</td>
>           </tr>
>         </table>
>       </div>
>     </div>
>   </div> <!-- his one is too much -->
>   </body>
> 
> plainText: "some random text\n"
> 
> 
> Diffs
> -----
> 
>   messageviewer/objecttreeparser.cpp bb951d7486dad2941409bffd930797026785b706 
>   messageviewer/tests/objecttreeparsertest.cpp fa9672b4d2249b509a84a3ff90829fd427a08e9c 
> 
> Diff: http://git.reviewboard.kde.org/r/109576/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/