[Kde-pim] Review Request 110993: kontact touch: remove "first steps" menu entry

Michael Bohlender michael.bohlender at kdemail.net
Thu Jun 13 17:20:30 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110993/#review34308
-----------------------------------------------------------



mobile/lib/kdeclarativemainview.cpp
<http://git.reviewboard.kde.org/r/110993/#comment25213>

    I don't see the point as accessing this via something like "application.openManual()" in QML looks way cleaner to me. Ideally we would define the whole UI in QML and only provide the functionality via C++.
    
    But then again: You are the expert.
    So: What shall I do?


- Michael Bohlender


On June 13, 2013, 11:16 a.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110993/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 11:16 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Removes "first steps" from the menu.
> The manual is still accessible through a link on StartCanvas.qml
> 
> 
> Diffs
> -----
> 
>   mobile/lib/ApplicationGeneralActions.qml 1c39a40 
>   mobile/lib/kdeclarativemainview.cpp cec6c9a 
> 
> Diff: http://git.reviewboard.kde.org/r/110993/diff/
> 
> 
> Testing
> -------
> 
> compiled, installed, started, visually confirmed, also opened via link on startcanvas.
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list