[Kde-pim] Review Request 111098: Fix FolderSelectionDialog not always selecting matching folders

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111098/#review34640
-----------------------------------------------------------

Ship it!


I tested in local. Seems good.
Ship it

- Laurent Montel


On June 18, 2013, 3:02 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111098/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 3:02 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Qt implementation of keyboard search interferes with FolderSelectionDialog type-ahead filtering.
> 
> Easiest way to reproduce the bug is to type slowly enough to cause QTreeView::keyboardSearch() to reset itself.
> 
> 
> This addresses bug 291389.
>     http://bugs.kde.org/show_bug.cgi?id=291389
> 
> 
> Diffs
> -----
> 
>   mailcommon/folder/foldertreeview.h 42b15d1e299687f461fbf9df57fed7f4eb5b2912 
>   mailcommon/folder/foldertreeview.cpp 16df11d924980b7e6e604da8ef4ec32aef528dd0 
>   mailcommon/folder/foldertreewidget.cpp fdeaa4c82751027cfb30de48a3e37dcc4c78d3db 
> 
> Diff: http://git.reviewboard.kde.org/r/111098/diff/
> 
> 
> Testing
> -------
> 
> Type filter characters slow enough, relevant items are still selected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/