[Kde-pim] Review Request 111101: Use QWeakPointer to store move|copy and selectfolder dialogs

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111101/#review34591
-----------------------------------------------------------



kmail/kmmainwidget.h
<http://git.reviewboard.kde.org/r/111101/#comment25393>

    not QPointer?



kmail/kmmainwidget.cpp
<http://git.reviewboard.kde.org/r/111101/#comment25394>

    is that necessary?
    I thought the smart pointers had an overloaded operator->() to make them appear like normal pointers



kmail/kmmainwidget.cpp
<http://git.reviewboard.kde.org/r/111101/#comment25395>

    can't you keep the condition conceptually and thus keep the body unchanged?
    something like
    if ( dialog->exec() && dialog )
    ?



kmail/kmmainwidget.cpp
<http://git.reviewboard.kde.org/r/111101/#comment25397>

    hmm. why break the pattern?


- Kevin Krammer


On June 18, 2013, 4:02 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111101/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 4:02 p.m.)
> 
> 
> Review request for KDEPIM and David Faure.
> 
> 
> Description
> -------
> 
> The code showing the move|copy and select folder dialogs tries to check the dialogs are not deleted while they are visible, but it actually recreates them instead of checking their existence. The patch changes this to use QWeakPointer to track the dialogs instead.
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.h 977e1e13a85d703f71c234697d5cf7fe72577843 
>   kmail/kmmainwidget.cpp 36e7164a58d59cd35f296b9ab6885f1de8c44572 
> 
> Diff: http://git.reviewboard.kde.org/r/111101/diff/
> 
> 
> Testing
> -------
> 
> Dialogs still show and work correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/