[Kde-pim] Review Request 111313: Minor string review

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111313/#review35332
-----------------------------------------------------------



headerthemeeditor/desktopfilepage.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25870>

    is there a reason available for this failure that could be added to the error message?



headerthemeeditor/editorpage.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25871>

    is there a reason available for this failure that could be added to the error message



headerthemeeditor/themeeditorpage.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25872>

    is there a reason available for this failure that could be added to the error message?
    



kmail/configuredialog/configuredialog.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25875>

    "The tag %1 cannot be created since a tag with that name already exists."



kmail/configuredialog/configuredialog.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25876>

    "The tag %1 cannot be created since a tag with that name already exists."
    



messageviewer/utils/util.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25873>

    is there a reason available for this failure that could be added to the error message?
    
    also do we know the name or any info for this particular message that would help the user identify which message failed to save?



pimsettingexporter/abstractimportexportjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25874>

    is there a reason available for this failure that could be added to the error message?
    



pimsettingexporter/abstractimportexportjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25877>

    How about "File %1 backup completed successfully."



pimsettingexporter/abstractimportexportjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25878>

    How about "File %1 backup completed successfully."
    



pimsettingexporter/abstractimportexportjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25879>

    How about "File %1 was backed up successfully."
    



pimsettingexporter/addressbook/exportaddressbookjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25880>

    How about "File %1 backup completed successfully."
    



pimsettingexporter/addressbook/exportaddressbookjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25884>

    "File %1 backup failed. <reason>"



pimsettingexporter/mail/exportmailjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25881>

    How about "File %1 backup completed successfully."
    



pimsettingexporter/mail/exportmailjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25882>

    How about "File %1 backup completed successfully."



pimsettingexporter/mail/exportmailjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25883>

    File %1 backup failed. <reason>



pimsettingexporter/mail/exportmailjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25885>

    "Mail %1 backup completed successfully."



pimsettingexporter/mail/exportmailjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25886>

    "Mail %1 backup failed. <reason>"



sendlateragent/sendlaterjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25887>

    "No message named %1 was found."
    
    if we know the name of the message, then let's tell the user about it in %1



sendlateragent/sendlaterjob.cpp
<http://git.reviewboard.kde.org/r/111313/#comment25888>

    "Unable to fetch message %1. %2"
    
    where %1 would be the name or some identifier for the message to give the user some clue as to what failed.


perhaps not such a minor string review.  what you suggested is better, but could be even nicer.  also depends on what changes the translators will allow at this stage of the release cycle.

- Allen Winter


On June 29, 2013, 7:03 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111313/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 7:03 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Just a few mistakes and might-be-betters found while translating.
> 
> 
> Diffs
> -----
> 
>   headerthemeeditor/desktopfilepage.cpp e301560 
>   headerthemeeditor/editorpage.cpp 242a858 
>   headerthemeeditor/themeeditormainwindow.cpp 7731934 
>   headerthemeeditor/themeeditorpage.cpp 3dd47a2 
>   kmail/configuredialog/configuredialog.cpp 47b32ef 
>   kmail/identity/identityeditvcarddialog.cpp 0729e5a 
>   messagecomposer/composer/kmeditor.cpp a05cc50 
>   messageviewer/utils/util.cpp 18717d4 
>   mobile/mail/AboutPage.qml b7e460e 
>   pimsettingexporter/abstractimportexportjob.cpp c926cce 
>   pimsettingexporter/addressbook/exportaddressbookjob.cpp 13ac357 
>   pimsettingexporter/mail/exportmailjob.cpp e399aab 
>   sendlateragent/sendlaterjob.cpp dd43ec6 
> 
> Diff: http://git.reviewboard.kde.org/r/111313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/