[Kde-pim] Review Request 111101: Use QPointer to store move|copy and selectfolder dialogs

Tue Jun 18 22:34:30 BST 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111101/
-----------------------------------------------------------

(Updated June 18, 2013, 11:34 p.m.)

Review request for KDEPIM and David Faure.

Changes
-------

Use QPointer instead of QWeakPointer

Summary (updated)
-----------------

Use QPointer to store move|copy and selectfolder dialogs

Description (updated)
-------

The code showing the move|copy and select folder dialogs tries to check the dialogs are not deleted while they are visible, but it actually recreates them instead of checking their existence. The patch changes this to use QPointer to track the dialogs instead.

Diffs (updated)
-----

  kmail/kmmainwidget.h 977e1e13a85d703f71c234697d5cf7fe72577843 
  kmail/kmmainwidget.cpp 36e7164a58d59cd35f296b9ab6885f1de8c44572 

Diff: http://git.reviewboard.kde.org/r/111101/diff/

Testing
-------

Dialogs still show and work correctly.

Thanks,

Aurélien Gâteau

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/