[Kde-pim] Review Request 111203: akonadiserver: Save as much as 60MB of heap space

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111203/#review34941
-----------------------------------------------------------

Ship it!


Nice find, thanks!

- Volker Krause


On June 23, 2013, 8:19 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111203/
> -----------------------------------------------------------
> 
> (Updated June 23, 2013, 8:19 p.m.)
> 
> 
> Review request for KDEPIM, Milian Wolff and Volker Krause.
> 
> 
> Description
> -------
> 
> This patch clears the query cache if it's unused for more than 30 seconds.
> 
> Tested with two clients connected ( korg, and korgac ).
> Massif pointed out 60MB of heap allocated to the QueryCache, massive blobs in libmysql.
> 
> The QueryCache was created to speed up mass operations, like deleting all items from a collection, after that, there's no use in keeping it around.
> Even if another mass operation arrives, it's just a few milliseconds to prepare the first query so it can be used for all following queries of this new mass-operation.
> 
> My akonadiserver is now running at 17MB when using jemalloc.
> ( with glibc malloc it's a bit more random, due to glibc's complicated policies to return memory to OS, sometimes it goes down to 17MB too, other times stays at 80MB ).
> 
> 
> Diffs
> -----
> 
>   server/src/storage/querycache.cpp 5b683d5 
> 
> Diff: http://git.reviewboard.kde.org/r/111203/diff/
> 
> 
> Testing
> -------
> 
> Re-ran massif with the patched server.
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/