[Kde-pim] Review Request 111112: Update version numbers used by kcalcore serializer

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111112/#review34883
-----------------------------------------------------------


I can't see any reason to object.
Sergio, what do you think?

- Allen Winter


On June 19, 2013, 10:11 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111112/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 10:11 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Update the libkcal version and add X-KDE-ICAL-IMPLEMENTATION-VERSION used by the akonadi serializer to what is currently used in kcalcore.
>     
> Because outdated version numbers were hardcoded, kcalcaore applied invalid backward compatibility workarounds. This fixes this so the workarounds are no longer used.
> In particular it caused lastModified/dtstamp and created to always be the same.
>     
> While this shouldn't be hardcoded, I hardcoded it once more because it is in a potentially performance relevant codepath and would thereforerequire further testing.
> 
> 
> Diffs
> -----
> 
>   plugins/akonadi_serializer_kcalcore.cpp d465c68189dcfe96940da42ececbc3d5eb872a3d 
> 
> Diff: http://git.reviewboard.kde.org/r/111112/diff/
> 
> 
> Testing
> -------
> 
> works for me. tests still pass.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/