[Kde-pim] Review Request 110221: Do not translate DavUtils::protocolName

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110221/#review35132
-----------------------------------------------------------


This review has been submitted with commit 962e8c301e2c90e9caaeabbddfcb5c0e0eaf03a3 by Grégory Oestreicher to branch KDE/4.10.

- Commit Hook


On May 6, 2013, 7:48 p.m., Yury Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110221/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 7:48 p.m.)
> 
> 
> Review request for KDEPIM and Grégory Oestreicher.
> 
> 
> Description
> -------
> 
> Do not translate DavUtils::protocolName
> 
> Dav resource assumes protocolName() to be untranslated in many places (e.g.,
> in protocolByName()).
> 
> 
> This addresses bug 298735.
>     http://bugs.kde.org/show_bug.cgi?id=298735
> 
> 
> Diffs
> -----
> 
>   resources/dav/common/davutils.h 48326213940ce156d877417a62e03e28ce50b67a 
>   resources/dav/common/davutils.cpp 9a64f24d0bb86bab6ead871e72447578900d5695 
> 
> Diff: http://git.reviewboard.kde.org/r/110221/diff/
> 
> 
> Testing
> -------
> 
> 1. Works for new resources.
> 2. Doesn't work for old resources even after sed'ing the rc file. It seems that the old (translated) string is hardcoded somewhere else (akonadi db?).
> 
> 
> Thanks,
> 
> Yury Kudryashov
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/