[Kde-pim] Review board

[Kevin Krammer]

On Thursday, 2013-06-13, Scarlett Clark wrote:
> On Thursday, June 13, 2013 11:32:57 PM Kevin Krammer wrote:
> > Hi,
> > 
> > On Thursday, 2013-06-13, Scarlett Clark wrote:
> > > Sorry to be a pain...
> > 
> > Not at all, initial setup is always a bit complicated.
> > 
> > > What is the secret to using the web interface?
> > > It does not like my diff file. I have tried to set up
> > > post-review on my machine, but every command
> > > I try fails miserably. I am not an expert with git
> > 
> > Hmm, I have to admit I never used he post-review tool myself, always
> > uploading the commits manually.
> > 
> > What I do is
> > 
> > git diff > /tmp/diff
> > 
> > and then using that file on git.reviewboard.kde.org when creating the
> > request.
> > 
> > Assuming "does not like my diff file" means that you are getting an error
> > message, what does it say?
> > 
> > Cheers,
> > Kevin
> 
> Thank you very much!! I was using the command line diff and not the git
> diff
> The latter was accepted by the web interface. I still have alot to learn,
> but progressing :)

:)
Tthe git diff command also adds some git specific information to its output 
which seems to be needed by reviewboard to correctly "apply" the patch.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20130613/81e66682/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/