[Kde-pim] Review Request 110829: Fix highlighting of spelling mistakes

[Laurent Montel]

> On June 6, 2013, 5:37 a.m., Laurent Montel wrote:
> > So configure->configure spelling->enable automatic spell checking is ignored which this patch.
> > So we need to find a method to hide this entry.
> > Otherwise for users this option doesn't work.
> >
> 
> Aurélien Gâteau wrote:
>     I just discovered this option yesterday afternoon. The simplest solution in my opinion is just to remove the checkbox. I don't expect this to matter, judging from the bug report, people are having a hard time finding it.
> 
> Aurélien Gâteau wrote:
>     I just realized this dialog comes from kdelibs :/ It's a bit more complicated then.
> 
> Laurent Montel wrote:
>     yes in kdelibs.
>     So don't know how we can do.
> 
> Aurélien Gâteau wrote:
>     I can see two options, with various level of hackishness:
>     
>     # Option 1
>     - Create the dialog ourself
>     - Find the checkbox with QWidget::findChildren() and hide it
>     - Show the dialog
>     
>     This is what I did here: http://paste.kde.org/759620 (not adding it to the current diff because it is for kdepim repository)
>     
>     # Option 2
>     
>     Modify KMComposeWin::slotAutoSpellCheckingToggled( bool on ) and KMComposeWin::slotSpellcheckConfig() so that in kmail2rc, Composer/autoSpellChecking and Spelling/checkerEnabledByDefault are kept in sync.
>     This would make the menu item "Options > Automatic Spellchecking" and the checkbox in the spellchecker config dialog behave as if they were the same setting.
>     
>     Option 2 is a bit less hackish, but more confusing for the end user.

I prefere option1
Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110829/#review33846
-----------------------------------------------------------


On June 4, 2013, 5:04 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110829/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 5:04 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Highlighting of errors was disabled if checkerEnabledByDefault() return false, which it does by default, leading to the strange situation where one could right-click on a misspelled word to get suggestions, but the misspelled words were not underlined.
> 
> Following the value of d->spellCheckingEnabled looks enough to me.
> 
> 
> This addresses bug 282541.
>     http://bugs.kde.org/show_bug.cgi?id=282541
> 
> 
> Diffs
> -----
> 
>   kpimtextedit/emailquotehighlighter.cpp aa3ebdf537196ae8915773c4826d263aa2654cfa 
> 
> Diff: http://git.reviewboard.kde.org/r/110829/diff/
> 
> 
> Testing
> -------
> 
> Tested with both HTML and plain text email: spelling mistakes are highlighted or not, depending on the value of "Options > Automatic Spellchecking".
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/