[Kde-pim] Review Request 110977: composer config general page: Move external editor group to its own tab

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110977/
-----------------------------------------------------------

(Updated June 13, 2013, 8:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Laurent Montel.


Description
-------

This patch moves the "External Editor" group from the General tab of the Composer config page to its own tab. This saves vertical space and makes the page fit netbook screens.

Composer config page already has many tabs, I believe the new situation is better nevertheless, especially since I expect very few people to be using the "External Editor" feature, so it's not a problem if it is in a tab on the far right.

All visible strings already exist, so this change does not break string freeze.


Diffs
-----

  kmail/configuredialog/configuredialog.cpp d030149e4d29c7bbe11e131352f4c51ac0df160e 
  kmail/configuredialog/configuredialog_p.h 0dfd77c29cc8f99f321598ad1fbe42eb7abe8b06 

Diff: http://git.reviewboard.kde.org/r/110977/diff/


Testing
-------


Thanks,

Aurélien Gâteau

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/