[Kde-pim] Review Request 110931: Move configuration of custom headers to a dialog

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110931/#review34268
-----------------------------------------------------------


This review has been submitted with commit 55602ce7f87cf170b276b3cde78e684202fead95 by Aurélien Gâteau to branch master.

- Commit Hook


On June 10, 2013, 10:55 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110931/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 10:55 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This changes moves the configuration of custom headers to a dialog, triggered by a "Configure Custom Headers" button. This is necessary to ensure the Appearance KCM fits a 1024x600 screen. I also moved the "Show spam status in fancy headers" checkbox together with this new button.
> 
> This change introduces two new strings: "Configure Custom Headers" and "Headers:", so if this is approved I am going to request approval from kde-i18n-doc before pushing it.
> 
> 
> Diffs
> -----
> 
>   kmail/configuredialog/configuredialog.cpp 64b8190d6d82305038850d863257b39643497efb 
>   kmail/configuredialog/configuredialog_p.h 0dfd77c29cc8f99f321598ad1fbe42eb7abe8b06 
>   messageviewer/header/customheadersettingwidget.h 54aab6b71fd90a42a4ab4bf64307b30d16cf996c 
>   messageviewer/ui/settings.ui 9149e1732e3d974a3a8c45915ff0a2552535adc5 
>   messageviewer/widgets/configurewidget.h 24dfc177f4d05a12ceee29503725dad5b70dce1f 
>   messageviewer/widgets/configurewidget.cpp 40434be1e777c6d402fc44367bc4faf5f7ded3b5 
> 
> Diff: http://git.reviewboard.kde.org/r/110931/diff/
> 
> 
> Testing
> -------
> 
> Changed custom headers, still works. Defaults are correctly reset by "defaults" button as well.
> 
> 
> File Attachments
> ----------------
> 
> screenshot of new layout
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/10/kmail.png
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/