[Kde-pim] Review Request 111089: Fix bug in running job count

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111089/#review34561
-----------------------------------------------------------



agents/nepomukfeeder/itemqueue.cpp
<http://git.reviewboard.kde.org/r/111089/#comment25362>

    given the coding style around this line I'd say it is missing spaces in the call parentheses



agents/nepomukfeeder/itemqueue.cpp
<http://git.reviewboard.kde.org/r/111089/#comment25363>

    same here and repeated later on



agents/nepomukfeeder/itemqueue.cpp
<http://git.reviewboard.kde.org/r/111089/#comment25366>

    also here



agents/nepomukfeeder/itemqueue.cpp
<http://git.reviewboard.kde.org/r/111089/#comment25367>

    I think you don't need the class and method name in the output, I think kWarning does internally



agents/nepomukfeeder/itemqueue.cpp
<http://git.reviewboard.kde.org/r/111089/#comment25368>

    spaces in parentheses



agents/nepomukfeeder/itemqueue.cpp
<http://git.reviewboard.kde.org/r/111089/#comment25369>

    emit?


- Kevin Krammer


On June 18, 2013, 12:41 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111089/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 12:41 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Fixes problem where the count of running jobs becomes less than zero (-1), causing an assert in itemqueue.cpp at line 113 to trigger. This was happening because ItemQueue::clear() was setting the running job count to zero when there was unfinished jobs, when the jobs actually did finish the running job count was decremented to below zero.
> 
> The batch fixes this by keeping a QList<KJob *> of running jobs, adding them when created and removing when the job finishes (via the result signal). When ItemQueue::clear() is called any outstanding jobs are silently killed and the list cleared.
> 
> 
> This addresses bug 321093.
>     http://bugs.kde.org/show_bug.cgi?id=321093
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/itemqueue.h d64f00e 
>   agents/nepomukfeeder/itemqueue.cpp 05a3491 
> 
> Diff: http://git.reviewboard.kde.org/r/111089/diff/
> 
> 
> Testing
> -------
> 
> Installed on my desktop and allowed to run. The feeder has stopped crashing - it was always crashing  withing a few minutes previously.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/