[Kde-pim] Review Request 111129: kmail-mobile: initialize settings page

[Michael Bohlender]

> On June 20, 2013, 12:38 p.m., Kevin Krammer wrote:
> > mobile/mail/StartPage.qml, line 38
> > <http://git.reviewboard.kde.org/r/111129/diff/2/?file=164810#file164810line38>
> >
> >     doesn't http://git.reviewboard.kde.org/r/111116/ remove the start page?

Nope. It removes the "KPIM.StartCanvas" with the id "startPage" from the file StartPage.qml. 
StartPage.qml was the original kmail-mobile.qml which I intend to split up into single pages. StartPage.qml will be removed by the end of this process.

Naming confusion. :)


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111129/#review34757
-----------------------------------------------------------


On June 19, 2013, 9:07 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111129/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 9:07 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Adds a Settings Page.
> Settings in PA are supposed to go into the global "settings" application.
> This is out of scope for my GSoC project so I will put all settings related stuff on this page.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/CMakeLists.txt 29d3e58 
>   mobile/mail/KMailActions.qml 01b0a59 
>   mobile/mail/SettingsPage.qml PRE-CREATION 
>   mobile/mail/StartPage.qml 9725f08 
>   mobile/mail/mainview.cpp 98d2633 
> 
> Diff: http://git.reviewboard.kde.org/r/111129/diff/
> 
> 
> Testing
> -------
> 
> opend and closed the settings page
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/