[Kde-pim] Review Request 110803: Use QFrame::StyledPanel instead of QFrame::Panel

Commit Hook null at kde.org
Tue Jun 4 08:42:31 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110803/#review33721
-----------------------------------------------------------


This review has been submitted with commit 08f73da6c70d57a2e3e5e3df8dbad7105419c88b by Aurélien Gâteau to branch master.

- Commit Hook


On June 3, 2013, 2:06 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110803/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 2:06 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Use QFrame::StyledPanel instead of QFrame::Panel
> 
> This ensure we get QStyle-compliant frames instead of win95-like frames.
> 
> This was done with a global search and replace on QFrame::Panel, I just left the progress dialog out as I was afraid it would look weird there. I am going to file a similar request for kdepimlibs repository.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/printing/ds_appearance.ui 082c43e817ed7781a743b37409e37aa6b634077e 
>   kmailcvt/kimportpagedlg.ui 467c7eeb1a74701a90e887c41e50d8489435db42 
>   kmailcvt/kselfilterpagedlg.ui b5873f8f7728b4fa81ddedaed0bb18b1a2e552a9 
>   korganizer/kcmdesignerfields.cpp c6507a7868e64a2179bd8be918496120be88bc6a 
>   libkdepim/kprefsdialog.cpp c368df5c1367ff4a2f2f0e765b73dc2be0056a9a 
>   libkleo/ui/keyrequester.cpp 95920b885d09e4af5fbeb517b5a48066cdfd02b5 
>   libkpgp/kpgpui.cpp 0cd3c708d11e09295654960f30d40c2cef2b4603 
>   templateparser/ui/templatesconfiguration_base.ui a027b9e1c7a7cd65290f82d393b814bec27d9b28 
> 
> Diff: http://git.reviewboard.kde.org/r/110803/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before-after
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/kmail.png
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list