[Kde-pim] Review Request 110818: use both the module and class name at the #include directive

Adrián Chaves Fernández adriyetichaves at gmail.com
Mon Jun 3 19:18:00 BST 2013 


> On June 3, 2013, 5:52 p.m., Laurent Montel wrote:
> > Don't ship it.
> > We removed it for Qt5
> > So it's normal that there is not "QtCore" or "QtGui"
> >

Does that mean that the coding policies need to change for Qt5? And if so, shouldn’t they change already so people starts, if not removing the module name, not adding it in other libraries and applications?


- Adrián


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110818/#review33678
-----------------------------------------------------------


On June 3, 2013, 5:23 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110818/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:23 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Description
> -------
> 
> As described at http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Qt_Includes
> I add the class name in the directive.
> 
> 
> Diffs
> -----
> 
>   akonadi/actionstatemanager.cpp e32b0fc 
>   akonadi/agentactionmanager.cpp 5afe086 
>   akonadi/agentbase.cpp acbacc3 
>   akonadi/agentfilterproxymodel.h 18486f8 
>   akonadi/agentinstancemodel.cpp 500749e 
>   akonadi/agentinstancewidget.h 98fbd66 
>   akonadi/agentinstancewidget.cpp e2fa1c5 
>   akonadi/agentmanager.cpp 03e4b1f 
>   akonadi/agentsearchinterface_p.h da2f7ab 
>   akonadi/agenttypedialog.cpp c20a451 
>   akonadi/agenttypemodel.cpp b8d33d6 
>   akonadi/agenttypewidget.h 43c3e50 
>   akonadi/agenttypewidget.cpp 8538b1e 
>   akonadi/calendar/calendarbase_p.h 443de40 
>   akonadi/calendar/calendarclipboard.h 058595b 
>   akonadi/calendar/calendarclipboard.cpp 2148841 
>   akonadi/calendar/calendarclipboard_p.h 45b3e40 
>   akonadi/calendar/calendarmodel.cpp 42559eb 
>   akonadi/calendar/calfilterproxymodel_p.h 45d17cf 
>   akonadi/calendar/etmcalendar.cpp e72b030 
>   akonadi/calendar/etmcalendar_p.h 564f674 
>   akonadi/calendar/examples/etmcalendar/main.cpp 14234cf 
>   akonadi/calendar/fetchjobcalendar_p.h 6532e89 
>   akonadi/calendar/freebusymanager.cpp 6ce3aeb 
>   akonadi/calendar/history.h 22b06d1 
>   akonadi/calendar/history_p.h 7628a7b 
>   akonadi/calendar/incidencechanger.h ba8172b 
>   akonadi/calendar/incidencechanger_p.h 9c108bf 
>   akonadi/calendar/itiphandler.h 5565509 
>   akonadi/calendar/itiphandler_p.h f3384eb 
>   akonadi/calendar/itiphandlerhelper_p.h f3b70fe 
>   akonadi/calendar/itiphandlerhelper_p.cpp 4871d32 
>   akonadi/calendar/kcolumnfilterproxymodel_p.h 7f3d4c0 
>   akonadi/calendar/mailclient_p.h af8bc10 
>   akonadi/calendar/mailscheduler_p.cpp bd1a750 
>   akonadi/calendar/publishdialog_p.cpp 12bfadf 
>   akonadi/calendar/standardcalendaractionmanager.cpp f2ef931 
>   akonadi/calendar/tests/calendarbasetest.cpp 2436f21 
>   akonadi/calendar/tests/etmcalendartest.cpp 0fe0f11 
>   akonadi/calendar/tests/fetchjobcalendartest.cpp 71d373e 
>   akonadi/calendar/tests/historytest.cpp cdafa62 
>   akonadi/calendar/tests/mailclienttest.cpp d5d2bfc 
>   akonadi/calendar/utils_p.h 715939a 
>   akonadi/changemediator_p.cpp 9f1983c 
>   akonadi/collectionattributessynchronizationjob.cpp 740805e 
>   akonadi/collectioncombobox.cpp 5209343 
>   akonadi/collectiondialog.h d80bc6b 
>   akonadi/collectiondialog_desktop.cpp 1b8d514 
>   akonadi/collectiondialog_mobile.cpp 3de3b3f 
>   akonadi/collectionfetchscope.cpp 368f143 
>   akonadi/collectionfilterproxymodel.h 55d559c 
>   akonadi/collectionfilterproxymodel.cpp 32915d3 
>   akonadi/collectionmodel.cpp 885bc5b 
>   akonadi/collectionmodel_p.cpp 9c31192 
>   akonadi/collectionpropertiesdialog.cpp a9fc89d 
>   akonadi/collectionpropertiespage.h bd329a0 
>   akonadi/collectionrequester.cpp 89ee3ac 
>   akonadi/collectionstatisticsdelegate.h f625676 
>   akonadi/collectionstatisticsdelegate.cpp f8ceebb 
>   akonadi/collectionstatisticsmodel.cpp 24d3557 
>   akonadi/collectionview.h 5975558 
>   akonadi/collectionview.cpp 0990d8b 
>   akonadi/conflicthandling/conflictresolvedialog.cpp 4bae50a 
>   akonadi/contact/abstractcontacteditorwidget_p.h 9cae6da 
>   akonadi/contact/actions/qekigadialer.cpp 18e3044 
>   akonadi/contact/actions/qsflphonedialer.cpp 37c9045 
>   akonadi/contact/actions/qskypedialer.cpp c6d6c9d 
>   akonadi/contact/actions/sendsmsaction.cpp 971fadf 
>   akonadi/contact/actions/smsdialog.cpp 30eb7dd 
>   akonadi/contact/autoqpointer_p.h 907b55c 
>   akonadi/contact/collectionfiltermodel_p.h 32474a2 
>   akonadi/contact/contacteditor.h cb38e39 
>   akonadi/contact/contacteditor.cpp 24a01c8 
>   akonadi/contact/contacteditordialog.cpp 3942823 
>   akonadi/contact/contacteditorpageplugin.h 8383b3c 
>   akonadi/contact/contactgroupeditor.h bdef787 
>   akonadi/contact/contactgroupeditor.cpp 7a308cc 
>   akonadi/contact/contactgroupeditordelegate.cpp e367239 
>   akonadi/contact/contactgroupeditordelegate_p.h be4eb7c 
>   akonadi/contact/contactgroupeditordialog.cpp 2cbf0de 
>   akonadi/contact/contactgrouplineedit.cpp 2e3ac3d 
>   akonadi/contact/contactgroupviewer.h daf691e 
>   akonadi/contact/contactgroupviewer.cpp 9c04e90 
>   akonadi/contact/contactgroupviewerdialog.cpp d696bae 
>   akonadi/contact/contactsfilterproxymodel.h 8d42f69 
>   akonadi/contact/contactviewer.h 2ef8802 
>   akonadi/contact/contactviewer.cpp 70033ac 
>   akonadi/contact/contactviewerdialog.cpp eac2250 
>   akonadi/contact/customfieldmanager.cpp 90df0b6 
>   akonadi/contact/editor/addresseditwidget.h 3932579 
>   akonadi/contact/editor/addresseditwidget.cpp 55b3a78 
>   akonadi/contact/editor/categorieseditwidget.h a075ff6 
>   akonadi/contact/editor/categorieseditwidget.cpp 98ae487 
>   akonadi/contact/editor/contacteditorwidget.cpp d0355d4 
>   akonadi/contact/editor/customfieldeditordialog.cpp 489f692 
>   akonadi/contact/editor/customfieldsdelegate.h f53449e 
>   akonadi/contact/editor/customfieldsdelegate.cpp cef8287 
>   akonadi/contact/editor/customfieldseditwidget.h 1a9f62f 
>   akonadi/contact/editor/customfieldseditwidget.cpp dc0cc6c 
>   akonadi/contact/editor/dateeditwidget.h 51df418 
>   akonadi/contact/editor/dateeditwidget.cpp b1e1af2 
>   akonadi/contact/editor/displaynameeditwidget.h 603b8d1 
>   akonadi/contact/editor/displaynameeditwidget.cpp 6bd0b43 
>   akonadi/contact/editor/emaileditwidget.cpp 3a358eb 
>   akonadi/contact/editor/freebusyeditwidget.h 6f2b433 
>   akonadi/contact/editor/freebusyeditwidget.cpp 5ae27a5 
>   akonadi/contact/editor/geoeditwidget.h fc25df5 
>   akonadi/contact/editor/geoeditwidget.cpp 46e88e9 
>   akonadi/contact/editor/im/imdelegate.h 7db1bdd 
>   akonadi/contact/editor/im/imeditordialog.cpp 01bbfe9 
>   akonadi/contact/editor/im/imitemdialog.cpp 4f01e80 
>   akonadi/contact/editor/imagewidget.h 4cd834a 
>   akonadi/contact/editor/imagewidget.cpp 459c336 
>   akonadi/contact/editor/imeditwidget.h 55f7952 
>   akonadi/contact/editor/imeditwidget.cpp 187a1c0 
>   akonadi/contact/editor/kdatepickerpopup.cpp 61a07fe 
>   akonadi/contact/editor/kdatepickerpopup_p.h a7aa70e 
>   akonadi/contact/editor/kedittagsdialog.cpp f02fdea 
>   akonadi/contact/editor/nameeditdialog.cpp 4329a55 
>   akonadi/contact/editor/nameeditwidget.h baffb06 
>   akonadi/contact/editor/nameeditwidget.cpp 9d6dd50 
>   akonadi/contact/editor/phoneeditwidget.cpp 800145c 
>   akonadi/contact/editor/secrecyeditwidget.h f3abcc8 
>   akonadi/contact/editor/secrecyeditwidget.cpp eba4605 
>   akonadi/contact/editor/soundeditwidget.h 3af68cf 
>   akonadi/contact/editor/soundeditwidget.cpp 91f47ba 
>   akonadi/contact/editor/tagwidget.h 7f6b3e3 
>   akonadi/contact/editor/tagwidget.cpp 974ff01 
>   akonadi/contact/emailaddressselectionwidget.h b8a6bff 
>   akonadi/contact/emailaddressselectionwidget.cpp 0d1c480 
>   akonadi/contact/kcm/kcmakonadicontactactions.cpp c9e650a 
>   akonadi/contact/leafextensionproxymodel_p.h 44086fb 
>   akonadi/contact/standardcontactactionmanager.cpp 66944da 
>   akonadi/contact/standardcontactformatter.cpp 8bbdb5f 
>   akonadi/contact/tests/emailaddressselectionwidgettest.h ca665af 
>   akonadi/contact/tests/emailaddressselectionwidgettest.cpp babcbfe 
>   akonadi/contact/textbrowser.cpp c2daed9 
>   akonadi/contact/waitingoverlay.cpp aac3513 
>   akonadi/contact/waitingoverlay_p.h 407b946 
>   akonadi/control.cpp bd4949a 
>   akonadi/dbusconnectionpool.cpp eacf100 
>   akonadi/dragdropmanager.cpp 6c22bf8 
>   akonadi/dragdropmanager_p.h 210be3e 
>   akonadi/entitycache_p.h bbc5b1e 
>   akonadi/entitydisplayattribute.h 53abe82 
>   akonadi/entitylistview.h a1fd723 
>   akonadi/entitylistview.cpp 75e6e5b 
>   akonadi/entitymimetypefiltermodel.h fb3e199 
>   akonadi/entityorderproxymodel.h 172c403 
>   akonadi/entityorderproxymodel.cpp b977a6c 
>   akonadi/entitytreemodel.cpp 5030c11 
>   akonadi/entitytreemodel_p.h 570b4c9 
>   akonadi/entitytreeview.h 9e9a7bc 
>   akonadi/entitytreeview.cpp b3e4677 
>   akonadi/entitytreeviewstatesaver.cpp d30219e 
>   akonadi/erroroverlay.cpp 4e116e6 
>   akonadi/erroroverlay_p.h a621df1 
>   akonadi/etmviewstatesaver.cpp 2ebe96f 
>   akonadi/exception.cpp f6dae81 
>   akonadi/favoritecollectionsmodel.cpp 16debbf 
>   akonadi/firstrun_p.h 069b005 
>   akonadi/itemmodel.cpp c3a3dfe 
>   akonadi/itemview.h c2251c0 
>   akonadi/itemview.cpp ffc031c 
>   akonadi/job.cpp 2fa564f 
>   akonadi/kdsignalblocker.cpp 5a5782e 
>   akonadi/kmime/addressattribute.cpp f74f2eb 
>   akonadi/kmime/markascommand_p.h 828b6c8 
>   akonadi/kmime/messagethreaderproxymodel.h 4e5e3bb 
>   akonadi/kmime/movecommand_p.h 709517b 
>   akonadi/kmime/movetotrashcommand_p.h 49f6fab 
>   akonadi/kmime/removeduplicatesjob.cpp b0c2fc6 
>   akonadi/kmime/specialmailcollectionsdiscoveryjob.cpp d0426b6 
>   akonadi/kmime/standardmailactionmanager.cpp 9f50cb7 
>   akonadi/kmime/tests/foldersrequester.h ae21854 
>   akonadi/kmime/tests/localfoldersrequestjobtest.cpp fab21e2 
>   akonadi/kmime/tests/localfolderstest.cpp 52ce8c7 
>   akonadi/kmime/tests/racetest.h b075af4 
>   akonadi/metatypes.h 01a1581 
>   akonadi/notes/noteutils.h 3397ebf 
>   akonadi/notes/tests/notestest.cpp fcf5a0f 
>   akonadi/progressspinnerdelegate.cpp 61696d2 
>   akonadi/progressspinnerdelegate_p.h f177804 
>   akonadi/recentcollectionaction.cpp 4f9a440 
>   akonadi/recentcollectionaction_p.h 05024a1 
>   akonadi/renamefavoritedialog.cpp 105bc64 
>   akonadi/resourcebase.cpp 20ab8a7 
>   akonadi/resourcesynchronizationjob.cpp 09aa978 
>   akonadi/selftestdialog.cpp 9231722 
>   akonadi/servermanager.cpp 45ab8c3 
>   akonadi/session.cpp 8657692 
>   akonadi/socialutils/imageprovider.cpp 148a40a 
>   akonadi/socialutils/socialfeeditem.h 5543ebd 
>   akonadi/socialutils/socialfeeditem_p.h 2ce8720 
>   akonadi/socialutils/socialnetworkattributes.h 28477d9 
>   akonadi/socialutils/socialnetworkattributes.cpp 24e6c9a 
>   akonadi/socialutils/tests/image-provider-tests.h e3fa265 
>   akonadi/socialutils/tests/image-provider-tests.cpp bed4f8b 
>   akonadi/specialcollectionsdiscoveryjob.cpp 2d36ae4 
>   akonadi/standardactionmanager.cpp 27c81de 
>   akonadi/statisticsproxymodel.h 44ae768 
>   akonadi/statisticsproxymodel.cpp 6237da6 
>   akonadi/subscriptiondialog.cpp e5a8ac6 
>   akonadi/subscriptionmodel.cpp c344dd9 
>   akonadi/tests/agentinstancewidgettest.h f27a80a 
>   akonadi/tests/agentinstancewidgettest.cpp 1e7ed35 
>   akonadi/tests/agenttypewidgettest.h f581e6e 
>   akonadi/tests/agenttypewidgettest.cpp ef7adab 
>   akonadi/tests/benchmarker/maildir/maildir.cpp b2188aa 
>   akonadi/tests/benchmarker/maildir/maildir20percentread.cpp e8b1c70 
>   akonadi/tests/benchmarker/maildir/maildirfetchallheaders.cpp 47d1519 
>   akonadi/tests/benchmarker/maildir/maildirfetchunreadheaders.cpp 9c5a912 
>   akonadi/tests/benchmarker/maildir/maildirimport.cpp 2e34fea 
>   akonadi/tests/benchmarker/maildir/maildirremovereadmessages.cpp e15da07 
>   akonadi/tests/benchmarker/maketest.h 3960c2f 
>   akonadi/tests/benchmarker/maketest.cpp c6fa87f 
>   akonadi/tests/benchmarker/vcard/vcard.h 24d801d 
>   akonadi/tests/benchmarker/vcard/vcardimport.cpp fc6dfd1 
>   akonadi/tests/cachetest.cpp 26fcf0e 
>   akonadi/tests/collectionmovetest.cpp e9b4386 
>   akonadi/tests/collectionsynctest.cpp f2102aa 
>   akonadi/tests/entitycachetest.cpp 736a017 
>   akonadi/tests/entitytreemodeltest.cpp 81eeb7b 
>   akonadi/tests/etm_test_app/mainwindow.h 14541ed 
>   akonadi/tests/etm_test_app/mainwindow.cpp 9d21550 
>   akonadi/tests/fakeakonadiservercommand.h 3a43c90 
>   akonadi/tests/fakeakonadiservercommand.cpp 7a103ca 
>   akonadi/tests/fakemonitor.cpp 4064766 
>   akonadi/tests/fakeserverdata.h 30a22c0 
>   akonadi/tests/fakeserverdata.cpp fffb0c1 
>   akonadi/tests/fakesession.cpp 37a7ba7 
>   akonadi/tests/firstrunner.cpp 228c243 
>   akonadi/tests/headfetcher.cpp 09710bd 
>   akonadi/tests/itemdumper.h 168b134 
>   akonadi/tests/itemdumper.cpp 63c87c2 
>   akonadi/tests/itemhydratest.h 8723251 
>   akonadi/tests/itemhydratest.cpp ce92537 
>   akonadi/tests/itemsynctest.cpp ca41e10 
>   akonadi/tests/modelspy.h 100478b 
>   akonadi/tests/modelspy.cpp c50f66a 
>   akonadi/tests/monitorfiltertest.cpp 1d3a135 
>   akonadi/tests/monitornotificationtest.cpp ecfbb2f 
>   akonadi/tests/monitortest.cpp 2b5aa47 
>   akonadi/tests/pluginloadertest.cpp f7498da 
>   akonadi/tests/proxymodelstest.cpp 7ed26e7 
>   akonadi/tests/selftester.cpp 57308c8 
>   akonadi/tests/sharedvaluepooltest.cpp 31e269a 
>   akonadi/tests/subscriber.cpp 8a60582 
>   akonadi/tests/test_utils.h 2f5405a 
>   akonadi/tests/testenvironmenttest.cpp 5e24f7c 
>   akonadi/tests/testrunner/setup.h 6013dc1 
>   akonadi/tests/testrunner/setup.cpp 2850e6a 
>   akonadi/tests/transactiontest.cpp ec4f370 
>   akonadi/trashjob.cpp 5a64908 
>   akonadi/trashrestorejob.cpp af6a7b3 
>   akonadi/trashsettings.cpp 18e882c 
> 
> Diff: http://git.reviewboard.kde.org/r/110818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list