[Kde-pim] Review Request 111101: Use QPointer to store move|copy and selectfolder dialogs

Commit Hook null at kde.org
Mon Jun 24 11:04:31 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111101/
-----------------------------------------------------------

(Updated June 24, 2013, 10:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and David Faure.


Description
-------

The code showing the move|copy and select folder dialogs tries to check the dialogs are not deleted while they are visible, but it actually recreates them instead of checking their existence. The patch changes this to use QPointer to track the dialogs instead.


Diffs
-----

  kmail/kmmainwidget.h 977e1e13a85d703f71c234697d5cf7fe72577843 
  kmail/kmmainwidget.cpp db8e479322b0c4881f809477c5bda0229b000c95 

Diff: http://git.reviewboard.kde.org/r/111101/diff/


Testing
-------

Dialogs still show and work correctly.


Thanks,

Aurélien Gâteau

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list