[Kde-pim] Review Request 111211: shorten the search in some cases

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111211/#review34957
-----------------------------------------------------------


Maybe it would be better to leave the calling code unchanged and instead add the emptiness test at the beginning of "bool SearchRuleString::matchesInternal( const QString &msgContents ) const" itself? This way other callers benefit from the change.

- Aurélien Gâteau


On June 24, 2013, 10:56 a.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111211/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 10:56 a.m.)
> 
> 
> Review request for KDEPIM and Andras Mantia.
> 
> 
> Description
> -------
> 
> as looking for asolution of bug #321186, in file kdepim/mailcomman/searchpattern.cpp
> I found that the variable msgContents is set to "empty" in the "else-case" of "if ( kasciistricmp( field(), ..."
> line 505.
> 
> In this case, we can set the variable rc to 0 and don't make the "matchesInternal", line 530.
> 
> 
> Diffs
> -----
> 
>   mailcommon/searchpattern.cpp 76a8808 
> 
> Diff: http://git.reviewboard.kde.org/r/111211/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/