[Kde-pim] Review Request 110981: Add public api for AgentType::agentCustomProperties

Dan Vrátil dvratil at redhat.com
Thu Jun 13 09:15:18 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110981/#review34258
-----------------------------------------------------------

Ship it!



akonadi/agenttype.h
<http://git.reviewboard.kde.org/r/110981/#comment25146>

    @since 4.1x



akonadi/agenttype.h
<http://git.reviewboard.kde.org/r/110981/#comment25144>

    You need to #include <QtCore/QVariantMap>, then you can use QVariantMap...



akonadi/agenttype.cpp
<http://git.reviewboard.kde.org/r/110981/#comment25145>

    ...and then you won't need to include it here :-)


- Dan Vrátil


On June 12, 2013, 7:01 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110981/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 7:01 p.m.)
> 
> 
> Review request for Akonadi, KDEPIM-Libraries, Dan Vrátil, and Volker Krause.
> 
> 
> Description
> -------
> 
> Implemented public kdepimlibs/akonadi api for the hopefully newly added agentCustomProperties.
> 
> See: https://git.reviewboard.kde.org/r/110980/
> 
> 
> Diffs
> -----
> 
>   akonadi/agentmanager.cpp 03e4b1f 
>   akonadi/agenttype.h 13d0af8 
>   akonadi/agenttype.cpp 98d1923 
>   akonadi/agenttype_p.h 05a8efd 
> 
> Diff: http://git.reviewboard.kde.org/r/110981/diff/
> 
> 
> Testing
> -------
> 
> Ported parts of webaccounts, worked great.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list