[Kde-pim] Review Request 111020: kmail: reduce minimum height of Security config page

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111020/#review34377
-----------------------------------------------------------

Ship it!


Seems good for me.
Ship it

- Laurent Montel


On June 14, 2013, 1:09 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111020/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 1:09 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This should be the last change necessary to make KMail configuration dialog fit in a netbook-sized screen. It is composed of two parts:
> 
> - A patch for SimpleStringListEditor which sets a size policy and define sizeHint(), making it possible to shrink the widget height to the height of its button column, but not more.
> 
> - The "Message Disposition Notification" group has been moved from the "Reading" tab to its own tab. The change reuses existing strings, so this does not break string freeze.
> 
> 
> Diffs
> -----
> 
>   kmail/CMakeLists.txt 7fbbaaff9c81e3312db10981db48b8295fa1092a 
>   kmail/configuredialog/configuredialog.cpp f228df12077f3c454e045bf561f5935d96d975b5 
>   kmail/configuredialog/configuredialog_p.h 8950b1ad97c52a4e5fd03e4d96b06d6afd47a70c 
>   kmail/ui/securitypagegeneraltab.ui c2dd4f9c703aec8054f2b5d107b1f6db62195d83 
>   kmail/ui/securitypagemdntab.ui PRE-CREATION 
>   pimcommon/widgets/simplestringlisteditor.h 13cef6b72aa2897a7ef8c3b31a9a5dcf7dadb679 
>   pimcommon/widgets/simplestringlisteditor.cpp 4683658947dab8192eef705a7a49b4838ff72415 
> 
> Diff: http://git.reviewboard.kde.org/r/111020/diff/
> 
> 
> Testing
> -------
> 
> - MDN settings are correctly set and reloaded.
> - Minimum size of KMail config dialog is now 808x567 with Oxygen widget style here.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/