[Kde-pim] Review Request 110980: Add agentCustomProperties to AgentType

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110980/#review34263
-----------------------------------------------------------



server/control/agentmanager.cpp
<http://git.reviewboard.kde.org/r/110980/#comment25147>

    style nitpick, move & to identifier



server/control/agenttype.cpp
<http://git.reviewboard.kde.org/r/110980/#comment25148>

    style nitpick: spaces inside parentheses



server/control/agenttype.cpp
<http://git.reviewboard.kde.org/r/110980/#comment25149>

    same here


- Kevin Krammer


On June 12, 2013, 5 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110980/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 5 p.m.)
> 
> 
> Review request for Akonadi, KDEPIM-Libraries, Dan Vrátil, and Volker Krause.
> 
> 
> Description
> -------
> 
> This allow to resource authors to add public properties to their resources that later on can be consumed by third parties like KDE-Accounts, pretty much like MimeTypes, Capabilities, Identifier...
> 
> For example, for KDE-Accounts we plan to add something like:
> 
> facebookresource.desktop:
> X-Akonadi-Custom-KDEAccounts=facebook-notifications,facebook-notes
> 
> That will indicate that the Facebook resource supports "KDEAccounts facebook-notifications and facebook-notes".
> 
> I'm still unsure about the name, either in the .desktop file entries or API. Suggestions welcomed.
> 
> Related review: https://git.reviewboard.kde.org/r/110981/
> 
> 
> Diffs
> -----
> 
>   interfaces/org.freedesktop.Akonadi.AgentManager.xml b35dfc7 
>   server/control/agentmanager.h a901b9f 
>   server/control/agentmanager.cpp d313f0f 
>   server/control/agenttype.h 937c9e5 
>   server/control/agenttype.cpp 08d4e1a 
> 
> Diff: http://git.reviewboard.kde.org/r/110980/diff/
> 
> 
> Testing
> -------
> 
> Tried the API developed in: https://git.reviewboard.kde.org/r/110981/ and used qdbus to see if it was working.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/