[Kde-pim] Review Request 110829: Fix highlighting of spelling mistakes

Commit Hook null at kde.org
Thu Jun 6 14:31:07 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110829/
-----------------------------------------------------------

(Updated June 6, 2013, 1:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Description
-------

Highlighting of errors was disabled if checkerEnabledByDefault() return false, which it does by default, leading to the strange situation where one could right-click on a misspelled word to get suggestions, but the misspelled words were not underlined.

Following the value of d->spellCheckingEnabled looks enough to me.


This addresses bug 282541.
    http://bugs.kde.org/show_bug.cgi?id=282541


Diffs
-----

  kpimtextedit/emailquotehighlighter.cpp aa3ebdf537196ae8915773c4826d263aa2654cfa 

Diff: http://git.reviewboard.kde.org/r/110829/diff/


Testing
-------

Tested with both HTML and plain text email: spelling mistakes are highlighted or not, depending on the value of "Options > Automatic Spellchecking".


Thanks,

Aurélien Gâteau

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list