[Kde-pim] Review Request 111414: kontact touch: remove KPIM.Spinner

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111414/#review35747
-----------------------------------------------------------



mobile/mail/StartPage.qml
<http://git.reviewboard.kde.org/r/111414/#comment26214>

    is BuysIndicator not an item as well?



mobile/mail/kmail-composer.qml
<http://git.reviewboard.kde.org/r/111414/#comment26215>

    does it do anything when running and not visible?
    otherwise you could bind running to parent.visible or window.busy


- Kevin Krammer


On July 6, 2013, 10:55 a.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111414/
> -----------------------------------------------------------
> 
> (Updated July 6, 2013, 10:55 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Replaces KPIM.Spinner in Kontact Touch (is only used in kmail-mobile) with PlasmaComponents.BusyIndicator.
> Removes KPIM.Spinner.
> 
> 
> Diffs
> -----
> 
>   mobile/lib/CMakeLists.txt 65ba2b4 
>   mobile/lib/Spinner.qml 203b9f3 
>   mobile/lib/images/CMakeLists.txt e66f1a2 
>   mobile/lib/images/loading/CMakeLists.txt 29fa8fa 
>   mobile/lib/images/loading/loading_1.png d879436 
>   mobile/lib/images/loading/loading_10.png bc6092d 
>   mobile/lib/images/loading/loading_11.png a8ddf8c 
>   mobile/lib/images/loading/loading_12.png 449df8b 
>   mobile/lib/images/loading/loading_13.png fc97929 
>   mobile/lib/images/loading/loading_14.png ab8fe0e 
>   mobile/lib/images/loading/loading_15.png 6edec2d 
>   mobile/lib/images/loading/loading_16.png 9c7f26d 
>   mobile/lib/images/loading/loading_17.png 1920626 
>   mobile/lib/images/loading/loading_18.png c0d4890 
>   mobile/lib/images/loading/loading_19.png e6970a6 
>   mobile/lib/images/loading/loading_2.png 2f82f71 
>   mobile/lib/images/loading/loading_20.png eb2945a 
>   mobile/lib/images/loading/loading_21.png c95ae07 
>   mobile/lib/images/loading/loading_22.png ac05c37 
>   mobile/lib/images/loading/loading_23.png aa99e81 
>   mobile/lib/images/loading/loading_24.png 9dbf44e 
>   mobile/lib/images/loading/loading_3.png c3b1026 
>   mobile/lib/images/loading/loading_4.png 8a82a13 
>   mobile/lib/images/loading/loading_5.png 7f34b63 
>   mobile/lib/images/loading/loading_6.png f9984d7 
>   mobile/lib/images/loading/loading_7.png cd00613 
>   mobile/lib/images/loading/loading_8.png 177a691 
>   mobile/lib/images/loading/loading_9.png 1afd429 
>   mobile/lib/qmldir ee8b9fa 
>   mobile/mail/StartPage.qml 607668f 
>   mobile/mail/kmail-composer.qml 1113c58 
> 
> Diff: http://git.reviewboard.kde.org/r/111414/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/