[Kde-pim] Review Request 111572: kmail-mobile: remove VacationScriptIndicator

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111572/#review36368
-----------------------------------------------------------

Ship it!


Keep the C++ parts. In general keeping the application core as functional as possible is a good idea, even if the UI doesn't expose features. This can later be made accessible through QML-only plugins, e.g. downloadable through Get Hot New Stuff or similar.

- Kevin Krammer


On July 18, 2013, 1:24 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111572/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 1:24 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Vacation stuff is not a planed feature (not even for after GSoC). Maybe we just forgot about it? I could add this to the current (temporary)folderPage. But as the name implies it is only temporary and will not work with the final version. There is also some C++ code. Should I remove that as well or keep it in case we want to re-enable this feature? Should I deactivate it in CMake then? Anyway the QML Code will not work for us so it has to go.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/CMakeLists.txt 360c64e 
>   mobile/mail/StartPage.qml a59d187 
>   mobile/mail/VacationScriptIndicator.qml 8fb0711 
> 
> Diff: http://git.reviewboard.kde.org/r/111572/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/