[Kde-pim] Review Request 111741: Implements --query command
Dan Vrátil
dvratil at redhat.com
Sat Jul 27 14:25:29 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111741/#review36592
-----------------------------------------------------------
kleopatra/commands/lookupcertificatescommand.cpp
<http://git.reviewboard.kde.org/r/111741/#comment26997>
No need to initialize QStringList
kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment26995>
Maybe you could just use KCmdLineArgs::allArguments() ?
kleopatra/kleopatraapplication.cpp
<http://git.reviewboard.kde.org/r/111741/#comment26996>
Conding style, probably should be
QString funcName( it1->opt );
- Dan Vrátil
On July 27, 2013, 3:14 p.m., Lindsay Mathieson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111741/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 3:14 p.m.)
>
>
> Review request for KDEPIM and Volker Krause.
>
>
> Description
> -------
>
> Added support for "--query <fingerprint>" command. Pre-loads search field and starts default keyserver search.
>
>
> This addresses bug 175980.
> http://bugs.kde.org/show_bug.cgi?id=175980
>
>
> Diffs
> -----
>
> kleopatra/commands/lookupcertificatescommand.h 80215fd
> kleopatra/commands/lookupcertificatescommand.cpp 289d322
> kleopatra/kleopatraapplication.h 202c937
> kleopatra/kleopatraapplication.cpp b39c0e5
>
> Diff: http://git.reviewboard.kde.org/r/111741/diff/
>
>
> Testing
> -------
>
> Started kleopatra from console with various options such as:
>
> kleopatra --query 04b8b187
>
> Keysearch dialog is displayed with correct parameters.
>
>
> Thanks,
>
> Lindsay Mathieson
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list