[Kde-pim] Review Request 111516: Improved Calendar

[Mark Gaiser]

> On July 15, 2013, 5:28 p.m., Kevin Krammer wrote:
> > qml/calendar/calendar.cpp, line 204
> > <http://git.reviewboard.kde.org/r/111516/diff/2/?file=170650#file170650line204>
> >
> >     I am not sure what the Plasma coding style is, but usually we use CamelCase in KDE, i.e. this would be nextYear()
> >     Also might be an idea to rename next/previous to nextMonth/previousMonth
> 
> Mark Gaiser wrote:
>     Hi Kevin,
>     
>     You're right, we should stay consistent even. Heena, please push this only with camelCase function names. No need to do previousMonth/nextMonth since those are my fault. I will fix those up.
> 
> Heena Mahour wrote:
>     Yes , I have pushed it using camelcase available here http://quickgit.kde.org/?p=kdepim-runtime.git&a=commitdiff&h=19472f2b92a4f3e42107678a136c7c9d027728f4&d=unified
> 
> Mark Gaiser wrote:
>     Feel free to push it to the branch "calendar_components" as well.

Note: be sure to add just like it's done on other places [1]:

REVIEW: 111516

to the commit message which will automatically close this request.
[1] http://quickgit.kde.org/?p=kdepim-runtime.git&a=commit&h=53f531d54d0e408e94c699068d8f9f462f5778f9


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111516/#review35989
-----------------------------------------------------------


On July 15, 2013, 1:02 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111516/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 1:02 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries, Mark Gaiser, and Marco Martin.
> 
> 
> Description
> -------
> 
> Added function to increment / decrement year required for my gsoc project .
> 
> 
> Diffs
> -----
> 
>   qml/calendar/calendar.h 46f4e4e 
>   qml/calendar/calendar.cpp c7ffe12 
> 
> Diff: http://git.reviewboard.kde.org/r/111516/diff/
> 
> 
> Testing
> -------
> 
> Testing : Successfull
> Works fine with QML .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/