[Kde-pim] Review Request 108974: Escape UIDs in resources that use them as filename

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108974/
-----------------------------------------------------------

(Updated July 10, 2013, 2:30 p.m.)


Review request for KDEPIM.


Changes
-------

- use KRandom::randomString()
- check that we don't accidentally overwrite an existing file


Description
-------

Contacts, vcarddir, icaldir and dav resources use KABC::Addressee::uid() or KCalCore::Incidence::uid() as part of the destination filenames. This fails if the UID contains unsafe characters like path delimiter, colon etc.

This patch uses QUrl::toPercentEncoding() to make sure the UID is safe to use.


Diffs (updated)
-----

  resources/contacts/contactsresource.cpp 499f56e 

Diff: http://git.reviewboard.kde.org/r/108974/diff/


Testing
-------

Successfully copied a contact from akonadi_googlecontacts_resource (which uses full http:// URL as UID) to akonadi_contacts_resource (which uses ~/.local/contacts/%contactUID%.vcard as filename).


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/