[Kde-pim] Review Request 111516: Improved Calendar

[Heena Mahour]

> On July 15, 2013, 12:34 p.m., Mark Gaiser wrote:
> > qml/calendar/calendar.cpp, line 206
> > <http://git.reviewboard.kde.org/r/111516/diff/1/?file=170648#file170648line206>
> >
> >     .addYear(1) seems like a better fit. Same for the other function but just "-1".

Done


> On July 15, 2013, 12:34 p.m., Mark Gaiser wrote:
> > qml/calendar/calendar.cpp, line 208
> > <http://git.reviewboard.kde.org/r/111516/diff/1/?file=170648#file170648line208>
> >
> >     Should not be needed since the month does not change. For a date like Feb. 29 (leap year) QDate will go back to Feb. 28 so there is no need to emit month changes.
> >     
> >     Same for the other function.

Done


- Heena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111516/#review35964
-----------------------------------------------------------


On July 15, 2013, 12:42 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111516/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 12:42 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Mark Gaiser.
> 
> 
> Description
> -------
> 
> Added function to increment / decrement year required for my gsoc project .
> 
> 
> Diffs
> -----
> 
>   qml/calendar/calendar.h 46f4e4e 
>   qml/calendar/calendar.cpp c7ffe12 
> 
> Diff: http://git.reviewboard.kde.org/r/111516/diff/
> 
> 
> Testing
> -------
> 
> Testing : Successfull
> Works fine with QML .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/