[Kde-pim] Review Request 109195: KIMAP: Handle unrequested BYE response

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109195/
-----------------------------------------------------------

(Updated July 28, 2013, 10:33 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries.


Description
-------

We have a Zimbra IMAP server that simply sends "BYE" after some time (don't know why or after what period), which seems to surprise KIMAP :-) When this happens, I can see 

A message was received from the server with no job to handle it: "* BYE X.Y.Z.redhat.com Zimbra IMAP4rev1 server closing connection " 

in console and when the IMAP resource tries to check emails after that, it crashes because KIMAP::Session expects socketTimer to be inactive, but because nobody handled the "BYE" response, nobody deactivated it.

I tried adding some handling for "BYE" response to Session::responseReceived() and now the crash is gone and when the "BYE" command arrives, the resource automatically tries reconnect.

ImapIdleManager::reconnect: attempting to reconnect IDLE session


This addresses bug 310887.
    http://bugs.kde.org/show_bug.cgi?id=310887


Diffs
-----

  kimap/session.cpp 4a43ac5 

Diff: http://git.reviewboard.kde.org/r/109195/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/