[Kde-pim] Review Request 111240: kmail-mobile: AccountsListPage

[Kevin Krammer]

> On June 25, 2013, 8:24 p.m., Kevin Krammer wrote:
> > mobile/mail/AccountsPage.qml, line 75
> > <http://git.reviewboard.kde.org/r/111240/diff/1/?file=165734#file165734line75>
> >
> >     Each resource/agent has an AgentType structure that should have an icon name set. might be better than using one for file servers?
> 
> Michael Bohlender wrote:
>     "icon: QIcon(model.type.iconName)" does not work. 
>     
>     Am I missing something obvious or do I have to change something on the C++ side?
>     
>     "  
>     // A list of agent instances
>       Akonadi::AgentInstanceModel *agentInstanceModel = new Akonadi::AgentInstanceModel( this );
>       d->mAgentInstanceFilterModel = new Akonadi::AgentFilterProxyModel( this );
>       d->mAgentInstanceFilterModel->addCapabilityFilter( QLatin1String( "Resource" ) );
>       d->mAgentInstanceFilterModel->setSourceModel( agentInstanceModel );
>     
>       context->setContextProperty( "agentInstanceList", QVariant::fromValue( static_cast<QObject*>( d->mAgentInstanceFilterModel ) ) );
>       d->mAgentInstanceSelectionModel = new QItemSelectionModel( d->mAgentInstanceFilterModel, this );
>     
>       setupAgentActionManager( d->mAgentInstanceSelectionModel );
>     "
>

Yes, seem we need to add another role for the icon.
Maybe by using a QIdentityProxyModel that adds an IconName role and puting it between the agentInstanceModel and the filter model


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111240/#review35074
-----------------------------------------------------------


On July 3, 2013, 9:36 a.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111240/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 9:36 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This is the base for the accounts list which will become the first page in the PageRow according to our mockup. 
> It is just for navigation and wont replace the accounts settings page.
> It does not make sense to activate this page until the other pages are ready.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/AccountsPage.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111240/diff/
> 
> 
> Testing
> -------
> 
> Started, interacted with. but deactivated again.
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/