[Kde-pim] Review Request 111469: Don't use 1.5 GB of memory when importing big maildir
Sergio Luis Martins
iamsergio at gmail.com
Wed Jul 10 23:20:27 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111469/
-----------------------------------------------------------
(Updated July 10, 2013, 10:20 p.m.)
Review request for KDEPIM and Volker Krause.
Description
-------
The code was creating 70k ItemCreateJobs first, and then starting them all. That makes mem usage reach a peak of 1.5GB here.
It does have code to do one event loop iteration every 20 e-mails, but that only makes it fire one ItemCreateJob, so they pile up anyway.
Solution is to throttle ItemCreationJob creation.
CPU-wise, this solution and the old one are equivalent, they are both equally fast.
Diffs
-----
resources/maildir/retrieveitemsjob.cpp 6afedec
resources/maildir/retrieveitemsjob.h dfc7095
Diff: http://git.reviewboard.kde.org/r/111469/diff/
Testing
-------
Imported a big maildir. Mem goes to 60MB max
Thanks,
Sergio Luis Martins
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list