[Kde-pim] Review Request 111289: Fix support for RSS feeds whose item links are not complete urls

[Frank Osterfeld]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111289/#review35580
-----------------------------------------------------------



syndication/tests/rss2/pennyarcade.xml
<http://git.reviewboard.kde.org/r/111289/#comment26122>

    Please add an XML comment somewhere here describing what's special about this test case (incomplete URLs)


Feel free to just push after the above is fixed.

- Frank Osterfeld


On June 28, 2013, 2:08 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111289/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 2:08 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Frank Osterfeld.
> 
> 
> Description
> -------
> 
> Fix support for RSS feeds whose item links are not complete urls.
> 
> Happens with some links from http://www.penny-arcade.com
> 
> Exemple of a faulty item:
> 
> <item>
>   <title><![CDATA[PAR Article: A cube with rough edges: PAR reviews the OUYA console, controller, and service]]></title>
>   <link>/report/article/a-cube-with-rough-edges-par-reviews-the-ouya-console-controller-and-service</link>
>   <description><![CDATA[Ben Kuchera:   Setting up the OUYA is an easy process. You plug in the power cable, plug in the HDMI cable, turn it on, and there you go. You then connect to a wireless network, set up an account, with or without a credit card attac
>   <author>bkuchera at penny-arcade.com (Ben Kuchera)</author>
>   <pubDate>2013-06-26T14:00:46+00:00</pubDate>
>   <guid>/report/article/a-cube-with-rough-edges-par-reviews-the-ouya-console-controller-and-service</guid>
> </item>
> 
> 
> Diffs
> -----
> 
>   syndication/rss2/item.cpp 65f04bcc5fdf4d7ea4efcca2350512251c0abc6f 
>   syndication/tests/rss2/pennyarcade.xml PRE-CREATION 
>   syndication/tests/rss2/pennyarcade.xml.expected PRE-CREATION 
>   syndication/tests/rss2/zeit.de.xml.expected de61b9be2502a6f61742029aa9bdbbd4ab3a277a 
> 
> Diff: http://git.reviewboard.kde.org/r/111289/diff/
> 
> 
> Testing
> -------
> 
> Tested with Penny Arcade feed. All links are now complete.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/