[Kde-pim] Review Request 111288: akregator: Support nested xml:base attributes

Frank Osterfeld frank.osterfeld at kdemail.net
Thu Jul 4 15:43:24 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111288/#review35578
-----------------------------------------------------------

Ship it!


- Frank Osterfeld


On June 28, 2013, 2:31 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111288/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 2:31 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Frank Osterfeld.
> 
> 
> Description
> -------
> 
> An atom feed can look like this:
> <feed xml:base="http://example.com/foo.atom">
>   <entry xml:base="subdir/">
>     <link href="foo.html"/>
>   </entry>
> </feed>
> 
> We need to parse the tree recursively up to the root to compute xmlBase.
> 
> 
> This addresses bug 117478.
>     http://bugs.kde.org/show_bug.cgi?id=117478
> 
> 
> Diffs
> -----
> 
>   syndication/elementwrapper.cpp 85373df3d8c1166b82802bd59849aed1a32b9b1f 
>   syndication/tests/atom/bug-190068.xml.expected a30649b98dbb86e97e0847f886aab10d2cc8653e 
>   syndication/tests/atom/tbray.org_nested_xmlbase.xml PRE-CREATION 
>   syndication/tests/atom/tbray.org_nested_xmlbase.xml.expected PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111288/diff/
> 
> 
> Testing
> -------
> 
> Tested with feed mentioned in bug report: http://www.tbray.org//ongoing/ongoing.atom
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list