[Kde-pim] Review Request 111566: kmai-mobile: remove New/Forward/Reply-Options-Page

Kevin Krammer krammer at kde.org
Thu Jul 18 13:25:38 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111566/#review36112
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Krammer


On July 18, 2013, 12:22 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111566/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 12:22 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Removes:
> ForwardOptionsPage
> ReplyOptionPage
> NewMailPage
> 
> We don't use StartPage anymore so there is no way to reach these pages. The basic functionality is already in the "new" app. The extended functionality is nice to have but not required for the first iteration of the app. We need a new PlasmaComponent (multiple actions button) to add it properly. This component is planed but not yet implemented. I see no way to add the extended functionality without breaking the user interaction. We have to live with the reduced functionality for the moment.
> 
> The plan is to remove Startpage.qml bit by bit so that we don't miss anything during our cleanup.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/CMakeLists.txt 9893418 
>   mobile/mail/ForwardOptionsPage.qml 5ca5765 
>   mobile/mail/KMailActions.qml d47e796 
>   mobile/mail/MailListPage.qml 3a6e8d9 
>   mobile/mail/MailViewPage.qml b9be876 
>   mobile/mail/NewMailPage.qml aa29fac 
>   mobile/mail/ReplyOptionsPage.qml cc92091 
> 
> Diff: http://git.reviewboard.kde.org/r/111566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list