[Kde-pim] Review Request 111741: Implements --query command

[Lindsay Mathieson]

> On July 27, 2013, 11:25 p.m., Dan Vrátil wrote:
> > kleopatra/kleopatraapplication.cpp, line 256
> > <http://git.reviewboard.kde.org/r/111741/diff/1/?file=173944#file173944line256>
> >
> >     Maybe you could just use KCmdLineArgs::allArguments() ?
> 
> Kevin Krammer wrote:
>     I think this is OK, the function right above has the very same signature, so this keeps the file's consistency

allArguments() returns the exe paths, options and arguments.
I thought args->getOptionsList("query") would be perfect but first it acted as a boolean, then when I specified the cmd option as "query <argument>" it stopped working altogether and broke the other arguments. Revisit after some sleep ...


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111741/#review36592
-----------------------------------------------------------


On July 27, 2013, 11:14 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111741/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 11:14 p.m.)
> 
> 
> Review request for KDEPIM and Volker Krause.
> 
> 
> Description
> -------
> 
> Added support for "--query <fingerprint>" command. Pre-loads search field and starts default keyserver search.
> 
> 
> This addresses bug 175980.
>     http://bugs.kde.org/show_bug.cgi?id=175980
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/lookupcertificatescommand.h 80215fd 
>   kleopatra/commands/lookupcertificatescommand.cpp 289d322 
>   kleopatra/kleopatraapplication.h 202c937 
>   kleopatra/kleopatraapplication.cpp b39c0e5 
> 
> Diff: http://git.reviewboard.kde.org/r/111741/diff/
> 
> 
> Testing
> -------
> 
> Started kleopatra from console with various options such as:
> 
>   kleopatra --query 04b8b187
> 
> Keysearch dialog is displayed with correct parameters.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/