[Kde-pim] Review Request 111313: Minor string review

[Laurent Montel]

> On June 30, 2013, 10:47 p.m., Allen Winter wrote:
> > headerthemeeditor/desktopfilepage.cpp, line 113
> > <http://git.reviewboard.kde.org/r/111313/diff/1/?file=166773#file166773line113>
> >
> >     is there a reason available for this failure that could be added to the error message?

no. Just zip informs that we can't do it


> On June 30, 2013, 10:47 p.m., Allen Winter wrote:
> > headerthemeeditor/editorpage.cpp, line 100
> > <http://git.reviewboard.kde.org/r/111313/diff/1/?file=166774#file166774line100>
> >
> >     is there a reason available for this failure that could be added to the error message

no. Just zip informs that we can't do it


> On June 30, 2013, 10:47 p.m., Allen Winter wrote:
> > sendlateragent/sendlaterjob.cpp, line 67
> > <http://git.reviewboard.kde.org/r/111313/diff/1/?file=166785#file166785line67>
> >
> >     "No message named %1 was found."
> >     
> >     if we know the name of the message, then let's tell the user about it in %1

We don't have name of this message


> On June 30, 2013, 10:47 p.m., Allen Winter wrote:
> > sendlateragent/sendlaterjob.cpp, line 81
> > <http://git.reviewboard.kde.org/r/111313/diff/1/?file=166785#file166785line81>
> >
> >     "Unable to fetch message %1. %2"
> >     
> >     where %1 would be the name or some identifier for the message to give the user some clue as to what failed.

We don't have it. Perhaps akonadi::item::id but it's not usefull


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111313/#review35332
-----------------------------------------------------------


On June 29, 2013, 7:03 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111313/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 7:03 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Just a few mistakes and might-be-betters found while translating.
> 
> 
> Diffs
> -----
> 
>   headerthemeeditor/desktopfilepage.cpp e301560 
>   headerthemeeditor/editorpage.cpp 242a858 
>   headerthemeeditor/themeeditormainwindow.cpp 7731934 
>   headerthemeeditor/themeeditorpage.cpp 3dd47a2 
>   kmail/configuredialog/configuredialog.cpp 47b32ef 
>   kmail/identity/identityeditvcarddialog.cpp 0729e5a 
>   messagecomposer/composer/kmeditor.cpp a05cc50 
>   messageviewer/utils/util.cpp 18717d4 
>   mobile/mail/AboutPage.qml b7e460e 
>   pimsettingexporter/abstractimportexportjob.cpp c926cce 
>   pimsettingexporter/addressbook/exportaddressbookjob.cpp 13ac357 
>   pimsettingexporter/mail/exportmailjob.cpp e399aab 
>   sendlateragent/sendlaterjob.cpp dd43ec6 
> 
> Diff: http://git.reviewboard.kde.org/r/111313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/