[Kde-pim] Review Request 111507: Add CHANGEDSINCE parameter to FETCH command

[Kevin Krammer]

> On July 15, 2013, 8:56 a.m., Christian Mollekopf wrote:
> > Regarding the feeder usage, how does this handle removals? It seems with this approach only new items would be detected and removals would be ignored?
> > The patch looks ok, but I agree with Kevin that this should be part of the fetchscope.
> 
> Dan Vrátil wrote:
>     Vishesh told me that he would improve the Akonadi search and Nepomuk KIO slave to effectively stat the Akonadi item before returning the result and dropping from results (and from Nepomuk) in case the item does not exist in Akonadi anymore.
>     
>     Anyway this should no happen very often - only when Nepomuk is not running while Akonadi is.

I guess Christian's question is more targetted at the general use case. I guess it is just not easy to ask a database for removed rows since a certain time?
Hmm, related question: is this something all backends support?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111507/#review35958
-----------------------------------------------------------


On July 14, 2013, 9:55 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111507/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 9:55 p.m.)
> 
> 
> Review request for Akonadi, Vishesh Handa and Volker Krause.
> 
> 
> Description
> -------
> 
> This allows clients to fetch from the Akonadi server only those items that have been changed since given timestamp. The syntax is CHANGEDSINCE %unixTimestamp%.
> 
> Usecase for this feature is mainly in the Nepomuk Feeder agent, which currently has to fetch all items from Akonadi and all items from Nepomuk on start up and compare them, to make sure the Nepomuk database is in sync with Akonadi. It causes high IO and high CPU and memory consumption during start, slowing down the start up. This feature will allow the Feeder to request only items that have changed since last time, which in most cases should mean no items at all.
> 
> 
> Diffs
> -----
> 
>   libs/protocol_p.h e94bf94 
>   server/src/akonadiconnection.cpp b8bcca3 
>   server/src/handler/fetchhelper.h 7f0f2b7 
>   server/src/handler/fetchhelper.cpp 78ea6ed 
>   server/src/handlerhelper.h 294b128 
>   server/src/handlerhelper.cpp e6d2f51 
> 
> Diff: http://git.reviewboard.kde.org/r/111507/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/