[Kde-pim] Review Request 111777: Replace use of 'whatsthis:' url with a QLabel-based implementation

Sergio Luis Martins iamsergio at gmail.com
Mon Jul 29 13:29:33 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111777/#review36739
-----------------------------------------------------------

Ship it!


- Sergio Luis Martins


On July 29, 2013, 12:16 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111777/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 12:16 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Replace use of 'whatsthis:' url with a QLabel-based implementation
> 
> This feature won't be available in KF5, since there is no KTextBrowser anymore. This implementation is similar to the code from kleopatra/dialogs/deletecertificatesdialog.cpp (see slotWhatsThisRequested() and UI constructor)
> 
> 
> Diffs
> -----
> 
>   calendarsupport/archivedialog.h 59743875b59084d6eb3b74240bf2f91763408d3c 
>   calendarsupport/archivedialog.cpp 7b966c708adf6a930db6a9aa67808c46db9ace0e 
> 
> Diff: http://git.reviewboard.kde.org/r/111777/diff/
> 
> 
> Testing
> -------
> 
> The link still shows the what's this text when clicked.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list