[Kde-pim] Review Request 111659: KPeople: Fix nicknames not appearing in PersonsModel without fetching IM Features.

[David Edmundson]

> On July 27, 2013, 2:20 p.m., Vishesh Handa wrote:
> > I'm not too sure about the change from QList to QSet. It doesn't seem like it achieves anything.
> > 
> > Other than that everything seems fine. Feel free to ship it with/without the QList -> QSet change. Your choice.

dropped the QSet change. It was wrong.

Added reserve() as suggested by Milian. 


> On July 27, 2013, 2:20 p.m., Vishesh Handa wrote:
> > src/personsmodelfeature.h, line 114
> > <http://git.reviewboard.kde.org/r/111659/diff/1/?file=173078#file173078line114>
> >
> >     annoying whitespace

dropped the QSet change. It was wrong.

Added reserve() as suggested by Millian. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111659/#review36572
-----------------------------------------------------------


On July 23, 2013, 4:03 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111659/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 4:03 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Replace use of nco:imNickName with nco:nickname
> 
> This allows for populating the nickname role of the model without
> needing to fetch all IM data.
> 
> KTp-nepomuk-feeder now populates the nco:nickname as well as the imNickName
> on the contact-medium. Plus potentially other sources will populate nco:nickname
> on the Contact item so we need to fetch it.
> 
> ---
> 
> Replace QList<PersonModelFeature> with QSet<..>
> 
> as order is not important
> 
> ---
> 
> Add convenience methods for instantiating model features
> 
> 
> Diffs
> -----
> 
>   src/autotests/tests/duplicatestests.cpp bd450a34c4f05d375747263a4660405651f53b95 
>   src/declarative/declarativepersonsmodel.cpp 9e625c8b5111fe3c609dffb7d3820b3ed3940db5 
>   src/examples/contactlistwidgets.cpp 9c444a3ec5c50eaf4b77274b655e166d1b3e28dd 
>   src/examples/duplicates.cpp 93dd7c96d0dc81f2cb3d514aef2ba99637189e97 
>   src/examples/mergededicateddialog.cpp 182406737579ebed6e8af98936db3e95765cdecf 
>   src/personsmodel.h f8dc4973143e4e238b11c9ecc1d3a9795b759577 
>   src/personsmodel.cpp 1e528ea0e00d19453d6df7435d6e1abe1daf9c29 
>   src/personsmodelfeature.h 854d4fdff7f7f0b94d4f3092d4d7c54c4a46a547 
>   src/personsmodelfeature.cpp 8fd47431dd73ced1ab92b895519eadc031ca2661 
> 
> Diff: http://git.reviewboard.kde.org/r/111659/diff/
> 
> 
> Testing
> -------
> 
> Updated PersonsViewer to only load the name+nickname+avatar everything works correctly and makes PersonsViewer faster \o/.
> Should fix the bug Aleix found.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/